Skip to content

[Schema Inaccuracy] Incorrect operationId #119

Closed
@rachmari

Description

@rachmari

Schema Inaccuracy

Originally reported by @gr2m in https://github.com/github/openapi/issues/340:

https://github.com/github/openapi/blob/fdd3f34435dc90c0db37126c795bc74f4076d820/definitions/operations/repos/update-status-check-potection.yml#L12

This should be repos/update-status-check-protection

- repos/update-status-check-potection
+ repos/update-status-check-protection

I'd be happy to send a pull request but I see the operationID show up in many files, and I'm not sure which need to be changed and which get updated automagically.

Also this needs a new entry in x-githubBreakingChanges:

  - type: operation
    date: '2020-07-29'
    note: '"repos/update-status-check-potection" operation ID is now "repos/update-status-check-protection"'
    before:
      operationId: repos/update-status-check-potection
    after:
      operationId: repos/update-status-check-protection

And the existing entry should be update, because it does actually not have the typo

  - type: operation
    date: '2020-06-04'
-   note: '"repos/update-protected-branch-required-status-checks" operation ID is now "repos/update-status-checks-protection"'
+   note: '"repos/update-protected-branch-required-status-checks" operation ID is now "repos/update-status-checks-potection"'
    before:
      operationId: repos/update-protected-branch-required-status-checks
    after:
-     operationId: repos/update-status-checks-protection
+     operationId: repos/update-status-checks-potection

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions