[Schema Inaccuracy] Innacurracies in the schema definition of the PingEvent
webhook (#/components/schemas/webhook-ping)
#1940
Labels
PingEvent
webhook (#/components/schemas/webhook-ping)
#1940
Schema Inaccuracy
These are some improvement I have found that could be made when comparing the current definition of the
PingEvent
to the definition inoctokit/webhooks
PingEvent
webhook, no property is marked as required. (Innacuracy)hook[config][content_type]
property can be augmented using anenum
, as indicated in it's description, the values would bejson
andform
hook[events]
property can be augmented to be aoneOf
, either anarray
with only the value*
for all events, or an array with anenum
of all possible webhook events, as done inoctokit/webhooks
hook[type]
property can be augmented to be anenum
of the different webhook types, eitherRepository
,Organization
, orApp
hook[config][insecure_ssl]
property can be augmented to be anenum
of either0
or1
as those are the only supported valuesExpected
For the properties to be marked as required.
The other issues aren't critical, they are values that could be defined more explicitly.
Reproduction Steps
n/a
The text was updated successfully, but these errors were encountered: