Skip to content

[Schema Inaccuracy] Pull Request Files Changed blob_url, raw_url, and sha should be nullable #1945

Open
@bigfootjon

Description

@bigfootjon

Schema Inaccuracy

When a PR changes a submodule, the blob_url and raw_url are null, in some other cases that I can't pin down the sha field is null. However, the current schema marks these fields as non-nullable.

Expected

blob_url, raw_url, and sha in PR files changed responses should be marked as nullable.

Reproduction Steps

$ curl https://api.github.com/repos/pytorch/pytorch/pulls/89846/files

The above PR changes a submodule, the fields can be seen to be nullable there.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions