You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The types "status" and "simple-commit-status" seem really similar, and it's quite debatable whether "simple" is any simpler than its colleague:
simple has a lot more typing (in that it has format specifiers, which status lacks)
simple has an additional required field, whose purpose is unexplained, which is both optional and nullable
status has an additional creator (nullable-simple-user)
simple flags description is nullable
Seems like the two could (and should) be unified, the divergences are pretty small and don't look like they should exist (especially the undocumented differences in nullability between the two's description field)
Also status should be an enum with the possible values (as far as I can tell "pending", "success", "error", or "failure", these are the statuses specifically enumerated for /repos/{owner}/{repo}/statuses/{sha})
The text was updated successfully, but these errors were encountered:
xmo-odoo
changed the title
[Schema Inaccuracy] Seeming redundancy between status and simpl-commit-status
[Schema Inaccuracy] Seeming redundancy between status and simple-commit-status
Jul 1, 2022
The types "status" and "simple-commit-status" seem really similar, and it's quite debatable whether "simple" is any simpler than its colleague:
simple
has a lot more typing (in that it hasformat
specifiers, whichstatus
lacks)simple
has an additionalrequired
field, whose purpose is unexplained, which is both optional and nullablestatus
has an additionalcreator
(nullable-simple-user)simple
flagsdescription
isnullable
Seems like the two could (and should) be unified, the divergences are pretty small and don't look like they should exist (especially the undocumented differences in nullability between the two's description field)
Also
status
should be an enum with the possible values (as far as I can tell "pending", "success", "error", or "failure", these are the statuses specifically enumerated for/repos/{owner}/{repo}/statuses/{sha}
)The text was updated successfully, but these errors were encountered: