Skip to content

Add support for NODE_OPTIONS for dd-trace (datadog agent) #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bmike78 opened this issue Apr 17, 2025 · 2 comments
Open

Add support for NODE_OPTIONS for dd-trace (datadog agent) #815

bmike78 opened this issue Apr 17, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@bmike78
Copy link

bmike78 commented Apr 17, 2025

Prerequisites:

  • Is the functionality available in the GitHub UI? If so, please provide a link to information about the feature.
    • technically this is a feature of the safe settings nodejs process

New Feature

  • We run a forked copy of safe settings and would like to provide some contributions upstream to be at parity with main-enterprise.

  • The feature we are looking to add is for NODE_OPTIONS and the addition of dd-trace to package.json for running a datadog sidecar as part of the pod deployment.

    • The helm chart would be updated as well to opt in with values for datadog to support the sidecar datadog-agent.
  • This would allow for adding any NODE_OPTIONS, for any other auto instrumentation or just other nice to have options for garbage collection, etc..

@bmike78 bmike78 added the enhancement New feature or request label Apr 17, 2025
@bmike78
Copy link
Author

bmike78 commented Apr 17, 2025

@decyjphr, just looking for your initial feedback on this to see if this is a feature that you would accept. If so, we can work on adding this as a PR.

@zpratt
Copy link

zpratt commented May 6, 2025

@decyjphr, another option for this that we can consider is that we use the opentelemetry agent npm package for automatic instrumentation as an additional dependency, since many of the common observability tools can ingest otel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants