Skip to content

Expression syntax highlighting doesn't seem to respect comments #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
max-sixty opened this issue Apr 29, 2023 · 3 comments
Open

Expression syntax highlighting doesn't seem to respect comments #158

max-sixty opened this issue Apr 29, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@max-sixty
Copy link

Describe the bug

Here, this line should appear as a comment:

image

To Reproduce

Here's the text:

  update-rust-toolchain:
    runs-on: ubuntu-latest
    # Don't run on forks; will attempt to create a PR into the fork...

    # if: ${{ !github.event.pull_request.head.repo.fork }}

Extension Version
v0.25.6

@max-sixty max-sixty added the bug Something isn't working label Apr 29, 2023
@cschleiden cschleiden changed the title if expression syntax highlighting doesn't seem to respect comments Expression syntax highlighting doesn't seem to respect comments May 8, 2023
@cschleiden
Copy link
Member

cschleiden commented May 8, 2023

Currently we always syntax highlight expressions in comments, that's not just limited to if expressions. It's due to the way we inject into the yaml grammar.

Since adding GitHub Actions Workflows as a separate language we could modify the yaml tm grammar if we wanted to.

@muzimuzhi
Copy link
Contributor

Since adding GitHub Actions Workflows as a separate workflow we could modify the yaml tm grammar if we wanted to.

Did you mean "as a separate language"?

@felipesu19 felipesu19 moved this from Backlog 🗒 to Triaged 📝 in GitHub Actions VS Code Extension May 15, 2023
@scott-doyland-burrows
Copy link

I noticed this as well, this just looks odd:

image

The entire comment should be shown in green, in my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Triaged 📝
Development

No branches or pull requests

4 participants