-
Notifications
You must be signed in to change notification settings - Fork 121
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
Describe the bug
When using in vscode.dev,
To Reproduce
Steps to reproduce the behavior:
- Open AdamRaichu/vscode-zip-viewer in vscode.dev. here
- Open the GitHub Actions view.
- Under the "WORKFLOWS" tab, expand "Publish Extension".
- The icons do not load.
Expected behavior
The icons should have loaded.
Screenshots
If applicable, add screenshots to help explain your problem.
Extension Version
v1.25.1
Additional context
The following errors were generated by the console following the steps above.
Not allowed to load local resource: file:///GitHub/vscode-github-actions/0.25.1/extension/resources/icons/dark/workflowruns/wr_success.svg
Not allowed to load local resource: file:///GitHub/vscode-github-actions/0.25.1/extension/resources/icons/dark/workflowruns/wr_failure.svg
I believe this error was caused by the method used to generate the icon paths. Perhaps using vscode.Uri.joinPath(extensionUri, "resources", "icons", "light OR dark", relativeIconPath)
would work better.
vscode-github-actions/src/treeViews/icons.ts
Lines 13 to 21 in 31e2001
export function getAbsoluteIconPath(relativeIconPath: string): { | |
light: string | vscode.Uri; | |
dark: string | vscode.Uri; | |
} { | |
return { | |
light: _context.asAbsolutePath(`resources/icons/light/${relativeIconPath}`), | |
dark: _context.asAbsolutePath(`resources/icons/dark/${relativeIconPath}`) | |
}; | |
} |
cschleiden
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity