Skip to content

Consider removing workspaceContains activation event #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TylerLeonhardt opened this issue Aug 14, 2023 · 0 comments
Open

Consider removing workspaceContains activation event #246

TylerLeonhardt opened this issue Aug 14, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@TylerLeonhardt
Copy link

Is your feature request related to a problem? Please describe.

This extension will eagerly activate if I have any workflow files in my repo... even if I don't intend to do any work on GitHub Actions in my repo.

This is because this extension has the following activation event:
https://github.com/github/vscode-github-actions/blob/main/package.json#L28

Describe the solution you'd like

Remove this activation event. Your extension will already activate when one of your views open or when you open a workflow file thanks to your registering of a language. This should be sufficient. If it's not, I'm curious to know why.

Additional context

Activating eagerly affects other extensions running in the extension host and the ideal situation is that only extensions that are absolutely needed are activated. This keeps VS Code & the extension host lean and fast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog 🗒
Development

No branches or pull requests

1 participant