Skip to content

Invalid warnings in problems for Github Actions YML #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kvenkatrajan opened this issue Apr 7, 2025 · 1 comment
Open

Invalid warnings in problems for Github Actions YML #463

kvenkatrajan opened this issue Apr 7, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@kvenkatrajan
Copy link

kvenkatrajan commented Apr 7, 2025

Describe the bug
This bug was originally created in this repo : microsoft/GitHub-Copilot-for-Azure#206 by accident

Missing required input app_location keeps appearing when it's missing from close pull request action:
close_pull_request_job:
if: github.event_name == 'pull_request' && github.event.action == 'closed'
runs-on: ubuntu-latest
name: Close Pull Request Job
steps:

  • name: Close Pull Request
    id: closepullrequest
    uses: Azure/static-web-apps-deploy@v1
    with:
    azure_static_web_apps_api_token: ${{ secrets.AZURE_STATIC_WEB_APPS_API_TOKEN}}
    action: "close"

To Reproduce
Steps to reproduce the behavior:

  1. With this workflow '...'
  2. Do this '...'
  3. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Extension Version
v1.x.y

Additional context
Add any other context about the problem here.

CC : Original user : aviscoreTH

@muzimuzhi
Copy link
Contributor

From its metadata (action.yml) and doc, the Azure/static-web-apps-deploy@v1 action does mark its input app_location required.

As the vscode-github-actions extension knows necessity of inputs from the action.yml of the corresponding action, I think the reported warning is valid, even if the input app_location is actually optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog 🗒
Development

No branches or pull requests

2 participants