Skip to content

Try to auto-detect which remote points to github.com #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sarisia opened this issue Mar 29, 2023 · 9 comments
Open

Try to auto-detect which remote points to github.com #50

sarisia opened this issue Mar 29, 2023 · 9 comments
Labels
enhancement New feature or request

Comments

@sarisia
Copy link

sarisia commented Mar 29, 2023

Is your feature request related to a problem? Please describe.

The extension couldn't find GitHub repository for the git repository when both of the following conditions are met:

  • git repository has two remotes
  • github url is not set as origin remote

i.e.:

$ git remote -v
github  https://github.com/my-org/my-repo.git (fetch)
github  https://github.com/my-org/my-repo.git (push)
origin  https://internal-scm.example.com/my-repo.git (fetch)
origin  https://internal-scm.example.com/my-repo.git (push)

Describe the solution you'd like
Let the extension detect GitHub repository from all the remotes, not only from origin.

Additional context

AFAIK GitHub CLI supports this scenario.

@sarisia sarisia added the enhancement New feature or request label Mar 29, 2023
@sarisia
Copy link
Author

sarisia commented Mar 29, 2023

I found the configuration github-actions.remote-name it works, but still think supporting auto-detection would be helpful.

@cschleiden cschleiden changed the title [feature request] support git repository which github remote is not origin Try to auto-detect which remote points to github.com Mar 31, 2023
@cschleiden
Copy link
Member

Thank you. I've updated the title slightly to reflect this.

@shirady
Copy link

shirady commented Apr 4, 2023

@sarisia / @cschleiden, would you please attach the steps on how to get to the configuration and change it?
Thanks!

@sarisia
Copy link
Author

sarisia commented Apr 4, 2023

#50 (comment)
@sarisia / @cschleiden, would you please attach the steps on how to get to the configuration and change it? Thanks!

  1. Open VSCode settings

    image

  2. Search for github-actions.remote-name

    image

@shirady
Copy link

shirady commented Apr 4, 2023

@sarisia, thank you!

@felipesu19
Copy link
Contributor

The latest release may fix this, though its possible there's more work to be done there, can you try it and let me know?

@sarisia
Copy link
Author

sarisia commented May 16, 2023

@felipesu19 Thank you for looking into this! Unfortunatelly, it's still not working.. (v0.25.7)

@felipesu19
Copy link
Contributor

Thank you for trying! i'll move it into issues to triage then!

@felipesu19 felipesu19 moved this from Backlog 🗒 to Triaged 📝 in GitHub Actions VS Code Extension May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Triaged 📝
Development

No branches or pull requests

5 participants
@cschleiden @sarisia @shirady @felipesu19 and others