Skip to content

Send raw data when uploading release asset #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2023
Merged

Send raw data when uploading release asset #11

merged 1 commit into from
Mar 21, 2023

Conversation

joshmgross
Copy link
Contributor

uploadReleaseAsset is expecting the raw data

GitHub expects the asset data in its raw binary form, rather than JSON. You will send the raw binary content of the asset as the request body.
https://octokit.github.io/rest.js/v19#repos-upload-release-asset

@joshmgross joshmgross requested a review from a team as a code owner March 21, 2023 22:06
@joshmgross joshmgross merged commit 7b4ff2d into main Mar 21, 2023
@joshmgross joshmgross deleted the joshmgross/fix-upload-release branch March 21, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cschleiden cschleiden

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshmgross @cschleiden