-
Notifications
You must be signed in to change notification settings - Fork 129
feat: add snippets for shells and workflow expressions #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hey @EmilySeville7cfg, Thanks for your contributions! Per our contributing guidelines, we'd prefer discussing features via an issue before they're implemented in a pull request. That will help us better understand the use case and how to solve it. |
@joshmgross, I've created an issue and explained the existing problem with this extension which snippets aiming to solve. |
@joshmgross, how long should I wait for any discussion? I just don't want to wait forever. |
Thanks for your contributions to the extension @EmilySeville7cfg At this point, we aren't ready to support snippets. |
@elbrenn, how do I know what is ready to be supported and what is not? Where can I find what kind of PRs are currently accepted? And, BTW, there was no any discussion in an opened issue:
Also, your guideline doesn't state that if PR is created without issue, it should be closed. I guess it has to be updated. I don't understand: why my PR was not closed by the first maintainer (@joshmgross) if it's not relevant for now? Sorry... but I have no wish to contribute to projects which don't state what contributors can work on now and reject PRs. |
Apologies for the disappointment here. Given our current capacity for maintaining this repo, we rely on solidifying new features in issues before we can work with a PR. We are not prepared to support snippets at this time. Thanks for your enthusiasm for the project and feedback about our contribution guidelines. We are working on clarifying expectations for response times on issues. |
I didn't provide snippets for functions, as I think when functions are needed it's better to write a separate shell script and just invoke it from workflow.
closes #36