Skip to content

Conversation

EmilyGraceSeville7cf
Copy link

@EmilyGraceSeville7cf EmilyGraceSeville7cf commented Mar 25, 2023

  • Snippets for workflow operators
  • Snippets for Bash, CMD, PowerShell compound commands
  • Snippets for sed, awk
  • Snippets for commands, triggers, steps, jobs

I didn't provide snippets for functions, as I think when functions are needed it's better to write a separate shell script and just invoke it from workflow.

closes #36

@EmilyGraceSeville7cf EmilyGraceSeville7cf requested a review from a team as a code owner March 25, 2023 05:59
@EmilyGraceSeville7cf EmilyGraceSeville7cf marked this pull request as draft March 25, 2023 06:07
@EmilyGraceSeville7cf EmilyGraceSeville7cf marked this pull request as ready for review March 25, 2023 06:17
@EmilyGraceSeville7cf EmilyGraceSeville7cf marked this pull request as draft March 25, 2023 06:57
@EmilyGraceSeville7cf EmilyGraceSeville7cf marked this pull request as ready for review March 25, 2023 07:17
@joshmgross
Copy link
Contributor

👋 Hey @EmilySeville7cfg,

Thanks for your contributions!

Per our contributing guidelines, we'd prefer discussing features via an issue before they're implemented in a pull request. That will help us better understand the use case and how to solve it.

@EmilyGraceSeville7cf
Copy link
Author

@joshmgross, I've created an issue and explained the existing problem with this extension which snippets aiming to solve.

@EmilyGraceSeville7cf
Copy link
Author

EmilyGraceSeville7cf commented Apr 2, 2023

Per our contributing guidelines, we'd prefer discussing features via an issue before they're implemented in a pull request. That will help us better understand the use case and how to solve it.

@joshmgross, how long should I wait for any discussion? I just don't want to wait forever.

@elbrenn
Copy link
Collaborator

elbrenn commented Apr 5, 2023

Thanks for your contributions to the extension @EmilySeville7cfg

At this point, we aren't ready to support snippets.

@EmilyGraceSeville7cf
Copy link
Author

EmilyGraceSeville7cf commented Apr 6, 2023

At this point, we aren't ready to support snippets.

@elbrenn, how do I know what is ready to be supported and what is not? Where can I find what kind of PRs are currently accepted? And, BTW, there was no any discussion in an opened issue:

We accept pull requests for bug fixes and features where we've discussed the approach in an issue and given the go-ahead for a community member to work on it.

Also, your guideline doesn't state that if PR is created without issue, it should be closed. I guess it has to be updated. I don't understand: why my PR was not closed by the first maintainer (@joshmgross) if it's not relevant for now? Sorry... but I have no wish to contribute to projects which don't state what contributors can work on now and reject PRs.

@EmilyGraceSeville7cf EmilyGraceSeville7cf deleted the feature/add-snippets branch April 6, 2023 09:52
@elbrenn
Copy link
Collaborator

elbrenn commented Apr 6, 2023

Apologies for the disappointment here. Given our current capacity for maintaining this repo, we rely on solidifying new features in issues before we can work with a PR. We are not prepared to support snippets at this time.

Thanks for your enthusiasm for the project and feedback about our contribution guidelines. We are working on clarifying expectations for response times on issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: snippets for workflow syntax and shell commands
3 participants