Skip to content

Update dev workspace with new language service repository #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions script/bootstrap
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,12 @@ root="$(dirname "$repo_root")"

# Clone dependent repos
echo "Cloning dependent repos..."
clone_repo https://github.com/github/actions-languageservices "$root"/actions-languageservices
clone_repo https://github.com/actions/languageservices "$root"/languageservices


# Copy workspace files
echo "Copying workspace files..."
cp "$repo_root"/script/workspace/package.json "$root"
cp "$repo_root"/script/workspace/vscode-github-actions.code-workspace "$root"
cp "$repo_root"/script/workspace/.npmrc "$root"
cp "$repo_root"/script/workspace/update-package-locks.sh "$root"
cp "$repo_root"/script/workspace/watch.sh "$root"
2 changes: 0 additions & 2 deletions script/workspace/.npmrc

This file was deleted.

10 changes: 5 additions & 5 deletions script/workspace/package.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"private": true,
"workspaces": [
"./actions-languageservices/expressions",
"./actions-languageservices/workflow-parser",
"./actions-languageservices/languageservice",
"./actions-languageservices/languageserver",
"./languageservices/expressions",
"./languageservices/workflow-parser",
"./languageservices/languageservice",
"./languageservices/languageserver",
"./vscode-github-actions"
]
}
}
2 changes: 1 addition & 1 deletion script/workspace/update-package-locks.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/bin/bash
set -e

for DIR in "actions-languageservices" "vscode-github-actions"
for DIR in "languageservices" "vscode-github-actions"
do
pushd $DIR
# Trigger an npm i without workspaces support to update the local package-lock.json
Expand Down
8 changes: 4 additions & 4 deletions script/workspace/vscode-github-actions.code-workspace
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"folders": [
{"path": "./actions-languageservices/expressions"},
{"path": "./actions-languageservices/workflow-parser"},
{"path": "./actions-languageservices/languageservice"},
{"path": "./actions-languageservices/languageserver"},
{"path": "./languageservices/expressions"},
{"path": "./languageservices/workflow-parser"},
{"path": "./languageservices/languageservice"},
{"path": "./languageservices/languageserver"},
{"path": "./vscode-github-actions"}
],
"extensions": {
Expand Down
2 changes: 1 addition & 1 deletion script/workspace/watch.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# allow killing all processes with ctrl-c
trap 'kill 0' SIGINT

for DIR in "actions-languageservices/expressions" "actions-languageservices/workflow-parser" "actions-languageservices/languageservice" "actions-languageservices/languageserver" "vscode-github-actions"
for DIR in "languageservices/expressions" "languageservices/workflow-parser" "languageservices/languageservice" "languageservices/languageserver" "vscode-github-actions"
do
pushd $DIR
npm run watch &
Expand Down