Skip to content

ability to send multiple resultsets from handleQuery #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions canal/canal.go
Original file line number Diff line number Diff line change
@@ -49,7 +49,7 @@ type Canal struct {
includeTableRegex []*regexp.Regexp
excludeTableRegex []*regexp.Regexp

delay *uint32
lastEventTimestamp *uint32

ctx context.Context
cancel context.CancelFunc
@@ -74,7 +74,7 @@ func NewCanal(cfg *Config) (*Canal, error) {
}
c.master = &masterInfo{}

c.delay = new(uint32)
c.lastEventTimestamp = new(uint32)

var err error

@@ -134,7 +134,7 @@ func (c *Canal) prepareDumper() error {
}

if c.dumper == nil {
//no mysqldump, use binlog only
// no mysqldump, use binlog only
return nil
}

@@ -175,7 +175,7 @@ func (c *Canal) prepareDumper() error {
}

func (c *Canal) GetDelay() uint32 {
return atomic.LoadUint32(c.delay)
return uint32(time.Now().Unix()) - atomic.LoadUint32(c.lastEventTimestamp)
}

// Run will first try to dump all data from MySQL master `mysqldump`,
7 changes: 1 addition & 6 deletions canal/sync.go
Original file line number Diff line number Diff line change
@@ -239,12 +239,7 @@ func (c *Canal) updateTable(db, table string) (err error) {
return
}
func (c *Canal) updateReplicationDelay(ev *replication.BinlogEvent) {
var newDelay uint32
now := uint32(time.Now().Unix())
if now >= ev.Header.Timestamp {
newDelay = now - ev.Header.Timestamp
}
atomic.StoreUint32(c.delay, newDelay)
atomic.StoreUint32(c.lastEventTimestamp, ev.Header.Timestamp)
}

func (c *Canal) handleRowsEvent(e *replication.BinlogEvent) error {
14 changes: 14 additions & 0 deletions mysql/result.go
Original file line number Diff line number Diff line change
@@ -19,3 +19,17 @@ func (r *Result) Close() {
r.Resultset = nil
}
}

func (r *Result) ChainResultSet(rs *Resultset) {
if r.Resultset == nil {
r.Resultset = rs
return
}

var lastRS *Resultset

for lastRS = r.Resultset; lastRS.Next != nil; lastRS = lastRS.Next {
}

lastRS.Next = rs
}
8 changes: 8 additions & 0 deletions mysql/resultset.go
Original file line number Diff line number Diff line change
@@ -17,6 +17,10 @@ type Resultset struct {
RawPkg []byte

RowDatas []RowData

// In the case of multiple queries, we will have there a chaining list of separated Resultset
Next *Resultset
filled bool
}

var (
@@ -266,3 +270,7 @@ func (r *Resultset) GetStringByName(row int, name string) (string, error) {
return r.GetString(row, column)
}
}

func (r *Resultset) IsFilled() bool {
return r.filled
}
2 changes: 2 additions & 0 deletions mysql/resultset_helper.go
Original file line number Diff line number Diff line change
@@ -123,6 +123,7 @@ func BuildSimpleTextResultset(names []string, values [][]interface{}) (*Resultse
r := new(Resultset)

r.Fields = make([]*Field, len(names))
r.filled = true

var b []byte

@@ -189,6 +190,7 @@ func BuildSimpleBinaryResultset(names []string, values [][]interface{}) (*Result
r := new(Resultset)

r.Fields = make([]*Field, len(names))
r.filled = true

var b []byte

22 changes: 21 additions & 1 deletion server/resp.go
Original file line number Diff line number Diff line change
@@ -181,7 +181,27 @@ func (c *Conn) writeValue(value interface{}) error {
return c.writeOK(nil)
case *Result:
if v != nil && v.Resultset != nil {
return c.writeResultset(v.Resultset)
for rs := v.Resultset; rs != nil; rs = rs.Next {
var err error

if rs.Next != nil {
c.status |= SERVER_MORE_RESULTS_EXISTS
}

if !rs.IsFilled() {
err = c.writeOK(v)
} else {
err = c.writeResultset(rs)
}

c.status &= ^SERVER_MORE_RESULTS_EXISTS

if err != nil {
return err
}
}

return nil
} else {
return c.writeOK(v)
}