Skip to content

issues Search Results · repo:js-org/js.org-cleanup language:JavaScript

Filter by

14 results
 (100 ms)

14 results

injs-org/js.org-cleanup (press backspace or delete to remove)

js-org/js.org-cleanup
Cleanup: Post in most recent request PR during automatic contact

For subdomains where we could not, or failed to, create an issue in the target repository, we should instead locate the most recent PR in the js.org repository for the subdomain and leave a comment there ...
enhancement
help wanted
  • MattIPv4
  • Opened 
    on Jun 7
  • #41

js-org/js.org-cleanup
Validate: Strip trailing periods from entries

https://github.com/js-org/js.org/pull/8873#discussion_r1512115698
bug
good first issue
  • MattIPv4
  • 2
  • Opened 
    on Mar 5, 2024
  • #27

js-org/js.org-cleanup
Validate: map netlify.com to netlify.app

https://github.com/js-org/js.org/pull/8480 migrated all netlify.com usage to netlify.app, and as such we should update the CNAME parsing logic in validation/cleanup to automatically map netlify.com subdomains ...
enhancement
good first issue
  • MattIPv4
  • Opened 
    on Sep 5, 2023
  • #25

js-org/js.org-cleanup
Cleanup: Support cleanup-ignore comment

Add support for entries having a // cleanup-ignore comment on them, which will allow them to skip the validation process for cleanup. This will also involve a minor change to the validate logic for detecting/formatting ...
enhancement
  • MattIPv4
  • 4
  • Opened 
    on Mar 15, 2023
  • #23

js-org/js.org-cleanup
Validate: Script does not exit code 1 when failing to find file

In a recent CI run, it was observed that the validate script output an error message stating it could not find the var declaration in the cnames_active.js, but this did not cause the CI run to fail. https://github.com/js-org/js.org/runs/8112104112?check_suite_focus=true ...
bug
good first issue
  • MattIPv4
  • Opened 
    on Aug 31, 2022
  • #16

js-org/js.org-cleanup
Validate: Require noCF flag for sub-sub-domains

When an entry is encountered in cnames_active.js that is for a sub-sub-domain (or deeper) (e.g. test.test : test.com), require that the // noCF flag is present for the entry.
enhancement
good first issue
  • MattIPv4
  • 1
  • Opened 
    on Aug 7, 2022
  • #15

js-org/js.org-cleanup
Validate: Handle targets being the same as subdomain

If an entry in cnames_active.js requests a target that is the same as the subdomain being requested (e.g. test : test.js.org), we should have an error.
enhancement
good first issue
  • MattIPv4
  • 1
  • Opened 
    on Aug 7, 2022
  • #14

js-org/js.org-cleanup
Validate: Handle keys with js.org suffixes

If an entry was present in the cnames_active.js file such as test.js.org : test.com, we should have an error for js.org being included in the key as a suffix.
enhancement
good first issue
  • MattIPv4
  • 1
  • Opened 
    on Aug 7, 2022
  • #13

js-org/js.org-cleanup
Validate: Diff line numbers inaccurate

See https://github.com/js-org/js.org/pull/7125/commits/5ecb09af0a9ce6529eb0c3317e41d96bd5825190 / https://github.com/js-org/js.org/runs/5806385291?check_suite_focus=true Line number for addition in diff ...
bug
  • MattIPv4
  • Opened 
    on Apr 3, 2022
  • #11

js-org/js.org-cleanup
Validate: Don't report removals before additions

When iterating through the diff in the validate command, if we encounter an added part immediately after a removed part, we report this as an expected/found diff: https://github.com/js-org/js.org-cleanup/blob/38697eb3e6f8e9982b7a8d85b1cf9f095f475e35/src/ci/validate.js#L84-L87 ...
bug
  • MattIPv4
  • 1
  • Opened 
    on Mar 28, 2022
  • #8
Issue origami icon

Learn how you can use GitHub Issues to plan and track your work.

Save views for sprints, backlogs, teams, or releases. Rank, sort, and filter issues to suit the occasion. The possibilities are endless.Learn more about GitHub Issues
ProTip! 
Restrict your search to the title by using the in:title qualifier.
Issue origami icon

Learn how you can use GitHub Issues to plan and track your work.

Save views for sprints, backlogs, teams, or releases. Rank, sort, and filter issues to suit the occasion. The possibilities are endless.Learn more about GitHub Issues
ProTip! 
Press the
/
key to activate the search input again and adjust your query.
Issue search results · GitHub