Skip to content

Use current quansight logo #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2025
Merged

Conversation

ngoldbaum
Copy link
Member

The Quansight marketing team asked me to update the logo on the numpy website.

Copy link

netlify bot commented May 23, 2025

Deploy Preview for numpy-org ready!

Name Link
🔨 Latest commit 5587ef8
🔍 Latest deploy log https://app.netlify.com/projects/numpy-org/deploys/68348fe85b4b8c00083d7640
😎 Deploy Preview https://deploy-preview-864--numpy-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ngoldbaum ngoldbaum force-pushed the new-quansight-logo branch from 4089a89 to 6183db5 Compare May 23, 2025 13:56
@ngoldbaum
Copy link
Member Author

current website:

image

proposed change:

image

tbh it looks a little less nice than it used to because the crop on the three logos isn't quite the same. Maybe there's a CSS tweak that would look nicer?

@melissawm
Copy link
Member

I was looking at this locally and could not find a css rule that solves all of it - basically because the Quansight logo has some whitespace at the top while the other logos don't:

Captura de imagem_20250523_115959

I think we can either crop the Quansight logo or add some padding to the other ones if we want this to look nice. I'm happy to look into it if you need help with the CSS stuff.

Copy link
Member

@InessaPawson InessaPawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is in my wheelhouse, I’ll chime in. If the goal is maintainable code and consistent UI, I recommend removing the excess whitespace from the logo image.

@ngoldbaum
Copy link
Member Author

I cropped the whitespace a bit and now it looks better.

Copy link
Member

@InessaPawson InessaPawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, @ngoldbaum!
@melissawm What do you think?

np-partners-v2

Here is a screenshot with the grid.

np-partners-v2grid

P.S. I'm somewhat tempted to reduce the size of the UC Berkeley logo to better match the font size of the other two, but that’s a conversation for a separate PR.

@InessaPawson InessaPawson requested a review from melissawm May 27, 2025 02:55
Copy link
Member

@melissawm melissawm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks @InessaPawson and @ngoldbaum !

@melissawm melissawm merged commit ef3cd04 into numpy:main May 27, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants