-
-
Notifications
You must be signed in to change notification settings - Fork 122
Use current quansight logo #864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for numpy-org ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
4089a89
to
6183db5
Compare
I was looking at this locally and could not find a css rule that solves all of it - basically because the Quansight logo has some whitespace at the top while the other logos don't: I think we can either crop the Quansight logo or add some padding to the other ones if we want this to look nice. I'm happy to look into it if you need help with the CSS stuff. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is in my wheelhouse, I’ll chime in. If the goal is maintainable code and consistent UI, I recommend removing the excess whitespace from the logo image.
I cropped the whitespace a bit and now it looks better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, @ngoldbaum!
@melissawm What do you think?

Here is a screenshot with the grid.

P.S. I'm somewhat tempted to reduce the size of the UC Berkeley logo to better match the font size of the other two, but that’s a conversation for a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, thanks @InessaPawson and @ngoldbaum !
The Quansight marketing team asked me to update the logo on the numpy website.