Skip to content

Improve account section terminology and labels #3509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 4, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/modules/IDE/components/Header/Nav.jsx
Original file line number Diff line number Diff line change
@@ -378,7 +378,7 @@ const AuthenticatedUserMenu = () => {
{t('Nav.Auth.MyAssets')}
</MenubarItem>
<MenubarItem id="account-settings" href="/account">
{t('Preferences.Settings')}
{t('Nav.Auth.MyAccount')}
</MenubarItem>
<MenubarItem id="account-logout" onClick={() => dispatch(logoutUser())}>
{t('Nav.Auth.LogOut')}
2 changes: 1 addition & 1 deletion client/modules/User/components/AccountForm.jsx
Original file line number Diff line number Diff line change
@@ -176,7 +176,7 @@ function AccountForm() {
</Field>
)}
<Button type="submit" disabled={submitting || invalid}>
{t('AccountForm.SubmitSaveAllSettings')}
{t('AccountForm.SaveAccountDetails')}
</Button>
</form>
)}
16 changes: 8 additions & 8 deletions client/modules/User/components/AccountForm.unit.test.jsx
Original file line number Diff line number Diff line change
@@ -61,8 +61,8 @@ describe('<AccountForm />', () => {
it('handles form submission and calls updateSettings', async () => {
subject();

const saveAllSettingsButton = screen.getByRole('button', {
name: /save all settings/i
const saveAccountDetailsButton = screen.getByRole('button', {
name: /save account details/i
});

const currentPasswordElement = screen.getByLabelText(/current password/i);
@@ -81,7 +81,7 @@ describe('<AccountForm />', () => {
});

await act(async () => {
fireEvent.click(saveAllSettingsButton);
fireEvent.click(saveAccountDetailsButton);
});

await waitFor(() => {
@@ -92,8 +92,8 @@ describe('<AccountForm />', () => {
it('Save all setting button should get disabled while submitting and enable when not submitting', async () => {
subject();

const saveAllSettingsButton = screen.getByRole('button', {
name: /save all settings/i
const saveAccountDetailsButton = screen.getByRole('button', {
name: /save account details/i
});

const currentPasswordElement = screen.getByLabelText(/current password/i);
@@ -110,12 +110,12 @@ describe('<AccountForm />', () => {
value: 'newPassword'
}
});
expect(saveAllSettingsButton).not.toHaveAttribute('disabled');
expect(saveAccountDetailsButton).not.toHaveAttribute('disabled');

await act(async () => {
fireEvent.click(saveAllSettingsButton);
fireEvent.click(saveAccountDetailsButton);
await waitFor(() => {
expect(saveAllSettingsButton).toHaveAttribute('disabled');
expect(saveAccountDetailsButton).toHaveAttribute('disabled');
});
});
});
4 changes: 2 additions & 2 deletions translations/locales/en-US/translations.json
Original file line number Diff line number Diff line change
@@ -367,13 +367,13 @@
"CurrentPasswordARIA": "Current Password",
"NewPassword": "New Password",
"NewPasswordARIA": "New Password",
"SubmitSaveAllSettings": "Save All Settings"
"SaveAccountDetails": "Save Account Details"
},
"AccountView": {
"SocialLogin": "Social Login",
"SocialLoginDescription": "Use your GitHub or Google account to log into the p5.js Web Editor.",
"Title": "p5.js Web Editor | Account Settings",
"Settings": "Account Settings",
"Settings": "My Account",
"AccountTab": "Account",
"AccessTokensTab": "Access Tokens"
},