-
Notifications
You must be signed in to change notification settings - Fork 146
Update reference regex to not break on beta versions #808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
hey @davepagurek , i would like to take this on and update regex to not break. |
@webermayank thanks for volunteering, and yes, both "1.2.3" and "1.2.3-beta.4" should be covered (so that 'v' is correctly prepended). Please make 2 PRs for both |
Hey @ksen0 , i just have a quick question
But i just recently saw that in this commit, this thing has already been implemented in so should i leave this part and just focus in regex in p5.js-website/blob/main/src/scripts/parsers/reference.ts ? |
@webermayank thanks for working on this and for your patience! First, the builds were breaking for an unrelated reason which should not be resolved (this one #831)
Good question, this is more about preventing future problems with beta deployments, while the memory of what goes wrong here is still fresh. |
Most appropriate sections of the p5.js website?
Reference
What is your operating system?
Mac OS
Web browser and version
Firefox
Actual Behavior
In the reference builder, we add a
v
to the start of the latest release if it seems to all be numeric:p5.js-website/src/scripts/parsers/reference.ts
Lines 26 to 28 in df16dae
This regex breaks for beta releases, e.g.
2.0.0-beta.5
. We're about to release 2.0 so we won't have beta releases for a while, but we may want this working for the future when we do beta 3.0 releases.Expected Behavior
The regex should match strings like
2.0.0-beta.5
too.Steps to reproduce
Manually edit this
p5.js-website/src/globals/p5-version.ts
Line 1 in df16dae
Would you like to work on the issue?
Feel free to take this on for me!
The text was updated successfully, but these errors were encountered: