Loads p5.min.js for CodeFrame iframes using manually created script
#224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…5.min.js. Avoids requiring a cached version of script by passing the text content of the script directly to the iframe.
|
@howard-e I think that the build is failing because |
stalgiag
reviewed
Apr 23, 2024
| // from running `draw` every frame, which helps performance | ||
| // on pages with multiple sketches, and causes sketch | ||
| // animations only to start when they become visible. | ||
| useLayoutEffect(() => { |
stalgiag
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #213.
This PR updates how
CodeFramecreatediframes make use ofp5.min.js.It avoids requiring a potentially cached version of the
p5.min.jsscript, by instead passing the text content of the script directly to the iframe to be included in a newly created script element.