Skip to content

Fix text stroke color not the same as the fill color #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

davepagurek
Copy link
Collaborator

Resolves #518

It looks like we add a stroke to text to make it bolder. There were a few cases where we would update the fill color of text but not the stroke color, leading to a slight different-colored halo around text. It was happening in links before, see below:

Before:
image

After:
image

That said, it looks like this text stroke may be the cause of #473. I'm not sure how standard this property is, and whether it's a good idea to be using it across the board on body text like this. Possibly a sign that we should just be using a thicker font instead?

@Qianqianye Qianqianye merged commit 333cbc2 into main Sep 17, 2024
4 checks passed
@Qianqianye Qianqianye deleted the fix/stroke-color branch September 17, 2024 00:14
@Qianqianye
Copy link
Collaborator

Thanks @davepagurek. I'm merging this solution for now, and we can have schedule a chat with the web designer with all the issues and PRs labelled Web Design soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jagged Hyperlink Text (Dark Mode)
2 participants