submission for shapeSVG library #847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @irenelfeng thanks for working on this! Could you please update the image to use a different name? p5.svg is already in use by https://github.com/zenozeng/p5.js-svg . Once that's done, happy to merge! |
irenelfeng
force-pushed
the
main
branch
2 times, most recently
from
f57f66c to
f2d6ccf
Compare
|
Thanks @irenelfeng ! If this library is compatible with p5.js 2.0 (you can change to this version in the p5.js Editor to check), please feel free to make a PR like this into the 2.0 branch of this repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no SVG reading support in p5js according to: https://www.gorillasun.de/blog/working-with-svgs-in-p5js/,
this library creates a loadSVG() function to load in an SVG and edit the style of each path in the XML file, and even individual vertices if need be.