Skip to content

Added portuguese (brazilian) translation for FES. #5591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

absurd-web
Copy link

Relevant: #4233

Changes:

I've added a portuguese (brazilian) translation for FES. I revised it and I am reasonably satisfied. Other speaker's suggestions would be appreciated.


PR Checklist

  • npm run lint passes

I have revised them and I am reasonably satisfied. I am open to other
eye's suggestios as well.
@welcome
Copy link

welcome bot commented Feb 5, 2022

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page!

@Qianqianye Qianqianye requested a review from almchung July 6, 2022 07:19
@almchung
Copy link

almchung commented Jul 8, 2022

Hi @absurd-web ! Welcome to p5.js, and thank you for taking the time to work on the Portuguese translation of Friendly Errors. I have some questions.

Would it be a good idea to specify the locale with a region designator (pt_BR)? What do you think? Also, what would be a good fallback language for pt/pt_BR?

And lastly, I also agree with you it would be great if we can get a second look from another Portuguese (Brazilian) speaker. Do you know a local group that can help you find a peer-reviewer? @outofambit and @Qianqianye do you know anyone who can help us on this? Or, we can deploy this version first and then let feedback/revisions happen naturally.

@Qianqianye
Copy link
Contributor

Qianqianye commented Jul 8, 2022

Maybe someone from the previous contributors @junagao @Henriquepb22 @mardefronteira @araucarialab @jlbrsl @tiagohermano @katzesoundz can help review the Portuguese translation? Thanks!

Copy link

@tiagohermano tiagohermano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems fine to me. Nice work 👍🏽

@Qianqianye
Copy link
Contributor

Would it be a good idea to specify the locale with a region designator (pt_BR)? What do you think? Also, what would be a good fallback language for pt/pt_BR?

Thanks for contributing @absurd-web. Wondering if you have might have thoughts for the question @almchung raised here?Thank you!

@Qianqianye
Copy link
Contributor

Hi @absurd-web, we'd like to follow up with this pull request, and we are wondering if you could respond to @almchung's previous comments.

Thanks @tiagohermano for the translation review!

Meanwhile, I'm inviting this year's GSoC FES contributor @Ayush23Dash and mentors @nbriz and @almchung to this conversation, so we can decide how to move forward with this PR. Thanks.

@Ayush23Dash
Copy link
Contributor

I think having a region designator would definitely be helpful @almchung .
At the same time, it would be great if we could get feedback from Portuguese language contributors about having a fallback language for pt_BR, if it is necessary or not; if it is not necessary in Portuguese Langugage's case then I believe we won't require the region designator as well(i.e. pt_BR)

@absurd-web
Copy link
Author

absurd-web commented Aug 21, 2023

Sorry about this very late response.

@Ayush23Dash I am not really sure about the fallback. If British English falls back to American English (or general, international, english), then Brazilian would be the fallback to a hypothetical European Portuguese translation, as I am assuming the number of speakers is the metric used in this case.
In any case I don't think an European Portuguese translation would look all that different, the same for the other lusophonic countries.
For these reasons I don't really think a designator is needed, @almchung .

If what is needed is instead a different language as fallback, then Spanish would be the best.

@Ayush23Dash
Copy link
Contributor

Thanks @absurd-web !!

In this case, I believe the current PR is good to go, without having a fallback language @almchung @Qianqianye

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: FES i18n
Development

Successfully merging this pull request may close these issues.

5 participants