-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Added portuguese (brazilian) translation for FES. #5591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I have revised them and I am reasonably satisfied. I am open to other eye's suggestios as well.
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page! |
Hi @absurd-web ! Welcome to p5.js, and thank you for taking the time to work on the Portuguese translation of Friendly Errors. I have some questions. Would it be a good idea to specify the locale with a region designator ( And lastly, I also agree with you it would be great if we can get a second look from another Portuguese (Brazilian) speaker. Do you know a local group that can help you find a peer-reviewer? @outofambit and @Qianqianye do you know anyone who can help us on this? Or, we can deploy this version first and then let feedback/revisions happen naturally. |
Maybe someone from the previous contributors @junagao @Henriquepb22 @mardefronteira @araucarialab @jlbrsl @tiagohermano @katzesoundz can help review the Portuguese translation? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems fine to me. Nice work 👍🏽
Thanks for contributing @absurd-web. Wondering if you have might have thoughts for the question @almchung raised here?Thank you! |
Hi @absurd-web, we'd like to follow up with this pull request, and we are wondering if you could respond to @almchung's previous comments. Thanks @tiagohermano for the translation review! Meanwhile, I'm inviting this year's GSoC FES contributor @Ayush23Dash and mentors @nbriz and @almchung to this conversation, so we can decide how to move forward with this PR. Thanks. |
I think having a region designator would definitely be helpful @almchung . |
Sorry about this very late response. @Ayush23Dash I am not really sure about the fallback. If British English falls back to American English (or general, international, english), then Brazilian would be the fallback to a hypothetical European Portuguese translation, as I am assuming the number of speakers is the metric used in this case. If what is needed is instead a different language as fallback, then Spanish would be the best. |
Thanks @absurd-web !! In this case, I believe the current PR is good to go, without having a fallback language @almchung @Qianqianye |
Relevant: #4233
Changes:
I've added a portuguese (brazilian) translation for FES. I revised it and I am reasonably satisfied. Other speaker's suggestions would be appreciated.
PR Checklist
npm run lint
passes