NaN and infinity check for isNumber #5846
Conversation
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page! |
| @@ -344,9 +344,9 @@ if (typeof IS_MINIFIED !== 'undefined') { | |||
| const isNumber = param => { | |||
| switch (typeof param) { | |||
| case 'number': | |||
| return true; | |||
| return isFinite(param); | |||
There was a problem hiding this comment.
I don't think finite number check should be implemented here as mentioned in the original issue there could still be utility for using Infinity in certain circumstances and if drawing functions are ever to enforce finite only numbers they should be done in the drawing functions themselves instead of in the general case here.
| case 'string': | ||
| return !isNaN(param); | ||
| return !(isNaN(param) || param == "null"); |
There was a problem hiding this comment.
There is another special case that needs to be accounted for here which is when param === "" or param === " " for any number of spaces in the string. Accounting for this can potentially add some complexity, alternatively we can attempt to do parseFloat(param) first to directly test if the result is NaN which also have the benefit of possibly not needing to use different switch cases here.
Resolves #5675
Changes:
Implemented an additional checker for null strings and infinite values in isNumber within validate_params.js
Screenshots of the change:
PR Checklist
npm run lintpasses