Fix typo in directionalLight reference (dev-2.0 branch) #7743 #7778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #7743 for version 2.0 |
3 tasks
|
@dhowe @davepagurek It looks to me like the Google Font is not loaded in the visual test case for some reason causing the test fail. |
|
I reran the tests and they passed, it seems like this one is flaky for some reason. I'm not sure how worrisome that is -- maybe there was a fluke accessing Google when the tests ran? but let's keep an eye out for this same test failure in case it's something to do with the fonts implementation. |
davepagurek
approved these changes
May 8, 2025
|
@all-contributors please add @LalitNarayanYadav for docs |
|
@LalitNarayanYadav already contributed before to doc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Fix incorrect reference to
p5.GeometryindirectionalLight()documentationDescription
This PR corrects a typo in the documentation comment for the
directionalLight()function.directionsets the light’s direction using ap5.Geometryobject.directionsets the light’s direction using ap5.Vectorobject.Since
p5.Vectoris the correct type used for directional light direction, this change improves the accuracy and clarity of the reference documentation in version 1.11.