Fix _isGlobal flag in ini method #7785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! 👍 |
ksen0
reviewed
May 12, 2025
src/core/main.js
Outdated
| @@ -709,8 +698,13 @@ class p5 { | |||
| // detects capitalization mistakes only ( Setup, SETUP, MouseClicked, etc) | |||
| p5._checkForUserDefinedFunctions(this); | |||
| } | |||
|
|
|||
| // Bind events to window (not using container div bc key events don't work) | |||
There was a problem hiding this comment.
Hi @VANSH3104, could you move this the comment a bit below please? So it continues to describe for (const e in this._events) {... Thank you!
ksen0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7781
Changes:
Screenshots of the change:
PR Checklist
npm run lintpasses