Terminate JVM of already running instances #1072
Merged
+10
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @AhmedMagedC Looks good! Code wise, would you be up for changing the code-flow that it becomes clearer when System.exit(0) is called? |
Stefterv
approved these changes
May 4, 2025
|
Done! what do you think @Stefterv? |
|
Perfect! thank you very much |
|
Thanks for your contribution @AhmedMagedC 💙 @all-contributors please add @AhmedMagedC for code |
|
I've put up a pull request to add @AhmedMagedC! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1066
Changes
added
System.exit(0)why?
when new Processing instance opens, a client socket is instantiated and connected to the main server socket (initiated by the main instance), then the main instance handles opening the sketch
but what about the instance that created the socket in the first place? we didn't terminate it's JVM, so it remains consuming resources and doing pretty much nothing
Tests
i validate the changes by trying to locally build multiple instances
everything works as expected, and these instances automatically exits