-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Open
Labels
type: enhancementnew feature or API change, should be merged into features branchnew feature or API change, should be merged into features branch
Description
As someone pointed out in my pytest training, pytest currently silently accepts:
def test_fixt(fixt=42):
...
with fixt
obviously being 42
in the test function no matter if such a fixture was ever defined or not.
There doesn't really seem any valid reason to do this kind of thing, yet some ideas float around how default argument like this could be used in the future with either test functions (e.g. #3834) or with fixture functions (e.g. #8109).
To avoid accidental usage and possibly allow for different usage in the future, should we maybe add a warning if default argument values are used like this?
RonnyPfannschmidt and Zac-HD
Metadata
Metadata
Assignees
Labels
type: enhancementnew feature or API change, should be merged into features branchnew feature or API change, should be merged into features branch
Activity
RonnyPfannschmidt commentedon Aug 6, 2024
We should also propose this as a potential ruff rule
huangbenny commentedon Dec 6, 2024
I can take this as my first issue
The-Compiler commentedon Jan 19, 2025
For what it's worth, flake8-pytest-style seems to have added a rule for this: https://github.com/m-burst/flake8-pytest-style/blob/master/docs/rules/PT028.md