Extra logging for fields when validation is disabled #824
Description
Is your feature request related to a problem? Please describe.
Currently there are such options as AllowUnknownMsgFields and ValidateUserDefinedFields. We are working in an environment where dictionary changes faster than we would like it to happen. At the same time we do not want messages to be rejected when some new field appears. So we set AllowUnknownMsgFields=Y and ValidateUserDefinedFields=N to allow messages new fields to come through. However, quickfix does not really say when field has been allowed through because of disabled validation.
Describe the solution you'd like
I would like quickfix to log fields which would fail validation if these two options would be AllowUnknownMsgFields=N and ValidateUserDefinedFields=Y. Something like
User Defined Field X is detected
Unknown message field X is detected
Metadata
Metadata
Assignees
Labels
Type
Projects
Milestone
Relationships
Participants
Activity
chrjohn commentedon Jun 14, 2024
I see that this might come in handy in one case or another. Want to submit a PR?
Edit: of course this should be disabled by default. :)
borkabu commentedon Jun 14, 2024
Would it need an extra option, something like EnableValidationLogging? Or maybe a couple of those LogUnknownMsgFields and LogUserDefinedFields
chrjohn commentedon Jun 14, 2024
To keep it simple, maybe just
FieldValidationLoggingwith a default ofN.borkabu commentedon Jun 17, 2024
One more thing related to this ticket. In the same manner I need to be able not to validate Enums, and log Unknown Enum value X for tag Y is detected, when the logging is on. So, it would require to add ValidateEnumValues flag (default Y).
chrjohn commentedon Jun 17, 2024
If you need that separate, OK with me. Otherwise I have nothing against having only
FieldValidationLoggingas config option.chrjohn commentedon Jun 25, 2024
@borkabu I don't know if you already started creating a PR for this: just wanted to let you know that I will merge #831 in due course which moves the validation settings into a separate class. But it will probably not affect you since you only want to act on the result of the validation and do not want to change the validation settings themselves.
borkabu commentedon Jun 29, 2024
Submitted PR.
I wonder if I do another PR against 2.3.1, what is the chance for 2.3.2 to be released?
chrjohn commentedon Jun 29, 2024
Next release will be 3.0.0.
I don't think there will be another 2.3.x unless for critical fixes.
borkabu commentedon Jun 29, 2024
Any thoughts on timeline for 3.0.0 then?
chrjohn commentedon Jun 29, 2024
Probably in the next weeks