Bug Fix: Auto import has broken for vim-lsp

[luoyancn]

1. Because of change the in 1, vim-lsp cannot complete the auto import items. May be, it`s better to use the method completion_item_edit_resolve 2 to resovle this problem. Also, maybe this change is only a workaround.

close the bug #19401

[ShoyuVanilla]

I think the current implementation is not problematic in general and "reverting" #18589 is not the right fix for this.

I might be wrong because I'm not familiar with implementation details of vim-lsp but plausible solution would be one of those:

• Check for the property "additionalTextEdits" here as well
  

  rust-analyzer/crates/rust-analyzer/src/lsp/capabilities.rs

  Lines 188 to 193 in 5b852da

  	fn completions_resolve_provider(&self) -> bool {
  	let client_capabilities = self.completion_resolve_support_properties();
  	let fields_to_resolve =
  	CompletionFieldsToResolve::from_client_capabilities(&client_capabilities);
  	fields_to_resolve != CompletionFieldsToResolve::empty()
  	}

• Make a workaround for vim-lsp as well, like in fix: Temporarily disable completion resolve support for helix and neovim #18630
• Fix vim-lsp to provide proper default client capabilities in here
• Edit your own vim script to provide proper client capabilities for rust-analyzer with this

[Veykril]

That seems like a bug in vim-lsp, rust-analyzer does not resolve additionalTextEdits lazily right now, so we do not consider it when declaring whether we have a resolve provider or not which is the correct behavior. Now, we probably could resolve it lazily as well, but that will only mask the bug in vim-lsp (as would adding a workaround for it like we do with neovim today, which has the same bug I believe)

[luoyancn]

@ShoyuVanilla Thanks for your advise.I will try to find much better solutions.

[rustbot]

⚠️ Warning ⚠️

• There are issue links (such as #123) in the commit messages of the following commits.
  Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.
  • e2fed14