Skip to content

ci: split x86_64-gnu-tools job #142245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2025
Merged

ci: split x86_64-gnu-tools job #142245

merged 1 commit into from
Jun 19, 2025
+125 −56

Conversation

marcoieni
Copy link
Member

@marcoieni marcoieni commented Jun 9, 2025 •
edited
Loading

Split the job to remove one large runner.

try-job: x86_64-gnu-tools
try-job: x86_64-gnu-miri
try-job: aarch64-gnu

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jun 9, 2025
@marcoieni
Copy link
Member Author

trying to write in the cache.

@bors2 try

@rust-bors
Copy link

rust-bors bot commented Jun 9, 2025

⌛ Trying commit f983d2f with merge 6815409…

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jun 9, 2025
@rust-bors
Auto merge of #142245 - marcoieni:split-gnu-tools, r=<try>
6815409 
ci: split x86_64-gnu-tools job

<!-- homu-ignore:start -->
<!--
If this PR is related to an unstable feature or an otherwise tracked effort,
please link to the relevant tracking issue here. If you don't know of a related
tracking issue or there are none, feel free to ignore this.

This PR will get automatically assigned to a reviewer. In case you would like
a specific user to review your work, you can assign it to them by using

    r? <reviewer name>
-->
r? `@ghost`
<!-- homu-ignore:end -->
try-job: x86_64-gnu-tools
try-job: x86_64-gnu-miri
@rust-bors
Copy link

rust-bors bot commented Jun 9, 2025

💔 Test failed

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@marcoieni
Copy link
Member Author

@bors2 try

@rust-bors
Copy link

rust-bors bot commented Jun 9, 2025

⌛ Trying commit 269bff1 with merge 39bd23a…

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jun 9, 2025
@rust-bors
Auto merge of #142245 - marcoieni:split-gnu-tools, r=<try>
39bd23a 
ci: split x86_64-gnu-tools job

<!-- homu-ignore:start -->
<!--
If this PR is related to an unstable feature or an otherwise tracked effort,
please link to the relevant tracking issue here. If you don't know of a related
tracking issue or there are none, feel free to ignore this.

This PR will get automatically assigned to a reviewer. In case you would like
a specific user to review your work, you can assign it to them by using

    r? <reviewer name>
-->
r? `@ghost`
<!-- homu-ignore:end -->
try-job: x86_64-gnu-tools
try-job: x86_64-gnu-miri
@marcoieni
Copy link
Member Author

Timing looks aligned with the rest of the PR jobs
image

r? @Kobzol

@marcoieni marcoieni marked this pull request as ready for review June 9, 2025 16:12
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 9, 2025
@rust-bors
Copy link

rust-bors bot commented Jun 9, 2025

☀️ Try build successful (CI)
Build commit: 39bd23a (39bd23afbc0976373e73e6d9271c31473becf05d)

Kobzol
Kobzol reviewed Jun 9, 2025
View reviewed changes
Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here (https://github.com/rust-lang/rust/actions/runs/15537420813/job/43739929375) the miri job took almost hour and a half :(

@marcoieni
Copy link
Member Author

@bors2 try

@rust-bors
Copy link

rust-bors bot commented Jun 9, 2025

⌛ Trying commit 269bff1 with merge 7176877…

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jun 9, 2025
@rust-bors
Auto merge of #142245 - marcoieni:split-gnu-tools, r=<try>
7176877 
ci: split x86_64-gnu-tools job

<!-- homu-ignore:start -->
<!--
If this PR is related to an unstable feature or an otherwise tracked effort,
please link to the relevant tracking issue here. If you don't know of a related
tracking issue or there are none, feel free to ignore this.

This PR will get automatically assigned to a reviewer. In case you would like
a specific user to review your work, you can assign it to them by using

    r? <reviewer name>
-->
Split the job to remove one large runner.
<!-- homu-ignore:end -->
try-job: x86_64-gnu-tools
try-job: x86_64-gnu-miri
@rust-bors
Copy link

rust-bors bot commented Jun 9, 2025

☀️ Try build successful (CI)
Build commit: 7176877 (7176877c055088535b7a65865b9fe7f97d1685fa)

@marcoieni
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented Jun 10, 2025

⌛ Trying commit f30e9c9 with merge 6642ca8...

bors added a commit that referenced this pull request Jun 10, 2025
@bors
Auto merge of #142245 - marcoieni:split-gnu-tools, r=<try>
6642ca8 
ci: split x86_64-gnu-tools job

try-job: x86_64-gnu-tools
try-job: x86_64-gnu-miri
@bors
Copy link
Collaborator

bors commented Jun 10, 2025

☀️ Try build successful - checks-actions
Build commit: 6642ca8 (6642ca8133464a9955669acb5c149e6d7fcaf1f4)

@marcoieni
Copy link
Member Author

The PR took 77 minutes. I don't know why the try build takes longer.

Should I split the miri job in x86_64-gnu-miri-1 and x86_64-gnu-miri-2 to get increase PR jobs speed?

@Kobzol
Copy link
Contributor

Kobzol commented Jun 10, 2025

Ah, because of this: https://github.com/rust-lang/rust/pull/142245/files#diff-d4ae5ae3c50d051afd7eb52e758cf5de0e2d57d1328a9f620af6c7c9af0a9274R13 It's special-cased to be faster on PRs.

Ok, I guess that 77 minutes isn't that terrible. Let's try it.

@bors r+ rollup=never

Marking as rollup=never because I want to see the test diff on this.

@bors
Copy link
Collaborator

bors commented Jun 10, 2025

📌 Commit f30e9c9 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 14, 2025
@marcoieni
Copy link
Member Author

marcoieni commented Jun 16, 2025 •
edited
Loading

Probably this was a flaky error because this PR should be independent from that job, but let's see.

@bors2 try

@rust-bors
Copy link

rust-bors bot commented Jun 16, 2025

⌛ Trying commit f30e9c9 with merge 93ee9c8…

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jun 16, 2025
@rust-bors
Auto merge of #142245 - marcoieni:split-gnu-tools, r=<try>
93ee9c8 
ci: split x86_64-gnu-tools job

<!-- homu-ignore:start -->
<!--
If this PR is related to an unstable feature or an otherwise tracked effort,
please link to the relevant tracking issue here. If you don't know of a related
tracking issue or there are none, feel free to ignore this.

This PR will get automatically assigned to a reviewer. In case you would like
a specific user to review your work, you can assign it to them by using

    r? <reviewer name>
-->
Split the job to remove one large runner.
<!-- homu-ignore:end -->
try-job: x86_64-gnu-tools
try-job: x86_64-gnu-miri
try-job: aarch64-gnu
@rust-bors
Copy link

rust-bors bot commented Jun 16, 2025

☀️ Try build successful (CI)
Build commit: 93ee9c8 (93ee9c86f7b3c3dea0eec5cbae5f92e38ff9d22d, parent: 68ac5abb067806a88464ddbfbd3c7eec877b488d)

@Kobzol
Copy link
Contributor

Kobzol commented Jun 16, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 16, 2025

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

@bors
Copy link
Collaborator

bors commented Jun 16, 2025

📌 Commit f30e9c9 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 16, 2025
bors added a commit that referenced this pull request Jun 17, 2025
@bors
Auto merge of #142245 - marcoieni:split-gnu-tools, r=Kobzol
3c0b265 
ci: split x86_64-gnu-tools job

try-job: x86_64-gnu-tools
try-job: x86_64-gnu-miri
try-job: aarch64-gnu
@bors
Copy link
Collaborator

bors commented Jun 17, 2025

⌛ Testing commit f30e9c9 with merge 3c0b265...

@marcoieni
Copy link
Member Author

wow, this PR must be cursed or something.

For some reason, building citool on mac took 1h and 40 minutes.

image

@marcoieni
Copy link
Member Author

Also other jobs took too much.
I wouldn't be surprised if this job times out
image

@bors
Copy link
Collaborator

bors commented Jun 17, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 17, 2025
@marcoieni
Copy link
Member Author

@bors r=Kobzol

@bors
Copy link
Collaborator

bors commented Jun 17, 2025

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
  • There's another pull request that is currently being tested, blocking this pull request: Sized Hierarchy: Part I #137944

@bors
Copy link
Collaborator

bors commented Jun 17, 2025

📌 Commit f30e9c9 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 17, 2025
@marcoieni
Copy link
Member Author

the PR failed to be merged for an unrelated error again.

@bors
Copy link
Collaborator

bors commented Jun 19, 2025

⌛ Testing commit f30e9c9 with merge 2fcf177...

@bors
Copy link
Collaborator

bors commented Jun 19, 2025

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing 2fcf177 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 19, 2025
@bors bors merged commit 2fcf177 into rust-lang:master Jun 19, 2025
11 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 19, 2025
@github-actions GitHub Actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 70e2b4a (parent) -> 2fcf177 (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 2fcf1776b9ccef89993dfe40e9f5c4908e2d2d48 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-gnu-tools: 5742.0s -> 3232.1s (-43.7%)
  2. dist-aarch64-linux: 7903.1s -> 5453.3s (-31.0%)
  3. x86_64-msvc-ext3: 7166.5s -> 6041.1s (-15.7%)
  4. dist-apple-various: 7063.0s -> 6344.2s (-10.2%)
  5. dist-x86_64-apple: 9037.8s -> 9884.2s (9.4%)
  6. x86_64-apple-1: 6939.8s -> 6425.4s (-7.4%)
  7. aarch64-gnu: 6145.5s -> 6507.1s (5.9%)
  8. dist-loongarch64-linux: 6240.6s -> 5891.8s (-5.6%)
  9. aarch64-apple: 4347.4s -> 4587.1s (5.5%)
  10. dist-various-1: 4097.4s -> 3885.7s (-5.2%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2fcf177): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.4% [0.4%, 0.4%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 1.8% [1.8%, 1.8%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.2% [-2.2%, -2.2%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.2% [-2.2%, 1.8%] 2

Cycles

Results (secondary -4.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -4.5% [-4.5%, -4.5%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 691.846s -> 692.244s (0.06%)
Artifact size: 372.01 MiB -> 371.99 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

@Kobzol Kobzol Kobzol left review comments

Assignees

@Kobzol Kobzol

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.
7 participants
@marcoieni @rust-log-analyzer @bors @Kobzol @rust-timer @RalfJung @rustbot