-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Let String pass #[track_caller] to its Vec calls #142728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Since this sometimes increases compile times @bors2 try |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
Let String pass #[track_caller] to its Vec calls I've added `#[track_caller]` to `String` methods that delegate to `Vec` methods that already have `#[track_caller]`. I've also added `#[track_caller]` to methods that have `assert!` or `panic!` due to invalid inputs.
Queued 075cf9a with parent 2fcf177, future comparison URL. |
Mind posting a difference in output with and without this change for reference? |
I've added
#[track_caller]
toString
methods that delegate toVec
methods that already have#[track_caller]
.I've also added
#[track_caller]
to methods that haveassert!
orpanic!
due to invalid inputs.