Skip to content

Bump to Node 20.19 #1569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025
Merged

Bump to Node 20.19 #1569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .devcontainer/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ RUN export DEBIAN_FRONTEND=noninteractive DEBCONF_NONINTERACTIVE_SEEN=true \

RUN mkdir -p /usr/local/nvm
ENV NVM_DIR /usr/local/nvm
ENV NODE_VERSION v20.18.2
ENV NODE_VERSION v20.19.0
RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.7/install.sh | bash
RUN /bin/bash -c "source $NVM_DIR/nvm.sh && nvm install $NODE_VERSION"
ENV NODE_PATH $NVM_DIR/versions/node/$NODE_VERSION/bin
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ jobs:
uses: actions/checkout@v4
- name: Build Extension
run: |
export NODE_VERSION=v20.18.2
export NODE_PATH=/usr/local/nvm/versions/node/v20.18.2/bin
export NODE_VERSION=v20.19.0
export NODE_PATH=/usr/local/nvm/versions/node/v20.19.0/bin
export NVM_DIR=/usr/local/nvm
. .github/workflows/scripts/setup-linux.sh
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"
Expand Down Expand Up @@ -53,8 +53,8 @@ jobs:
needs_token: true
# Linux
linux_env_vars: |
NODE_VERSION=v20.18.2
NODE_PATH=/usr/local/nvm/versions/node/v20.18.2/bin
NODE_VERSION=v20.19.0
NODE_PATH=/usr/local/nvm/versions/node/v20.19.0/bin
NVM_DIR=/usr/local/nvm
CI=1
VSCODE_SWIFT_VSIX_ID=${{needs.package.outputs.artifact-id}}
Expand All @@ -80,8 +80,8 @@ jobs:
# Linux
linux_exclude_swift_versions: '[{"swift_version": "5.8"}, {"swift_version": "5.9"}, {"swift_version": "5.10"}, {"swift_version": "6.0"}, {"swift_version": "nightly-6.1"}, {"swift_version": "nightly-main"}]'
linux_env_vars: |
NODE_VERSION=v20.18.2
NODE_PATH=/usr/local/nvm/versions/node/v20.18.2/bin
NODE_VERSION=v20.19.0
NODE_PATH=/usr/local/nvm/versions/node/v20.19.0/bin
NVM_DIR=/usr/local/nvm
CI=1
VSCODE_VERSION=insiders
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ jobs:
uses: actions/checkout@v4
- name: Build Extension
run: |
export NODE_VERSION=v20.18.2
export NODE_PATH=/usr/local/nvm/versions/node/v20.18.2/bin
export NODE_VERSION=v20.19.0
export NODE_PATH=/usr/local/nvm/versions/node/v20.19.0/bin
export NVM_DIR=/usr/local/nvm
. .github/workflows/scripts/setup-linux.sh
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"
Expand Down Expand Up @@ -50,8 +50,8 @@ jobs:
# Linux
linux_exclude_swift_versions: '[{"swift_version": "nightly-6.1"},{"swift_version": "nightly-main"}]'
linux_env_vars: |
NODE_VERSION=v20.18.2
NODE_PATH=/usr/local/nvm/versions/node/v20.18.2/bin
NODE_VERSION=v20.19.0
NODE_PATH=/usr/local/nvm/versions/node/v20.19.0/bin
NVM_DIR=/usr/local/nvm
CI=1
FAST_TEST_RUN=${{ contains(github.event.pull_request.labels.*.name, 'full-test-run') && '0' || '1'}}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/scripts/setup-linux.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
##
##===----------------------------------------------------------------------===##

export NODE_VERSION=v20.18.2
export NODE_PATH=/usr/local/nvm/versions/node/v20.18.2/bin
export NODE_VERSION=v20.19.0
export NODE_PATH=/usr/local/nvm/versions/node/v20.19.0/bin
export NVM_DIR=/usr/local/nvm

apt-get update && apt-get install -y rsync curl gpg libasound2 libgbm1 libgtk-3-0 libnss3 xvfb build-essential
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/scripts/windows/install-nodejs.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
$NODEJS='https://nodejs.org/dist/v20.18.2/node-v20.18.2-x64.msi'
$NODEJS='https://nodejs.org/dist/v20.19.0/node-v20.19.0-x64.msi'
$NODEJS_SHA256='c2654d3557abd59de08474c6dd009b1d358f420b8e4010e4debbf130b1dfb90a'
Set-Variable ErrorActionPreference Stop
Set-Variable ProgressPreference SilentlyContinue
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
20.18.2
20.19.0