Skip to content

Try to fix project panel tests #1623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 17, 2025
Merged

Try to fix project panel tests #1623

merged 2 commits into from
Jun 17, 2025

Conversation

award999
Copy link
Contributor

Issue: #1610

@award999 award999 added the full-test-run Perform a full test suite run. Apply this label before pushing up a PR or commit label Jun 16, 2025
@award999 award999 marked this pull request as ready for review June 17, 2025 12:19
@award999 award999 requested a review from plemarquand June 17, 2025 12:58
@award999
Copy link
Contributor Author

@plemarquand I moved the build step to after the tree provider getting initialized since you had logic in there to grab focus when a task runs

rbenegal
rbenegal approved these changes Jun 17, 2025
View reviewed changes
Copy link
Contributor

@rbenegal rbenegal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

tracymiranda
tracymiranda approved these changes Jun 17, 2025
View reviewed changes
Copy link
Contributor

@tracymiranda tracymiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@award999 award999 merged commit 8d0f0c3 into swiftlang:main Jun 17, 2025
34 of 36 checks passed
@award999 award999 deleted the project-panel-tests branch June 17, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tracymiranda tracymiranda tracymiranda approved these changes

@matthewbastien matthewbastien matthewbastien approved these changes

@rbenegal rbenegal rbenegal approved these changes

@adam-fowler adam-fowler Awaiting requested review from adam-fowler adam-fowler is a code owner

@0xTim 0xTim Awaiting requested review from 0xTim 0xTim is a code owner

@plemarquand plemarquand Awaiting requested review from plemarquand

Assignees
No one assigned
Labels
full-test-run Perform a full test suite run. Apply this label before pushing up a PR or commit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@award999 @tracymiranda @matthewbastien @rbenegal