-
-
Notifications
You must be signed in to change notification settings - Fork 621
Add fill tool support on strokes #2664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add fill tool support on strokes #2664
Conversation
Test cases: |
9741537
to
1a64e29
Compare
See the video for the issues this encounters: capture_10_.mp4Here's the file with this shape (remove the |
@Keavon The issue does not seem to affect shapes constructed using pen tool: ellipse_vs_path_shapes_fill_overlay.mp4 |
You likely need to take into account the local transform, the nested transform spaces to reach from local space to document space, and the stroke transform (which is affected by scaling or skewing a grouped layer, for example). |
!build |
|
34dced3
to
5cacab2
Compare
…ty while showing overlays
7f66924
to
535fba8
Compare
I have force pushed this branch to move it to a new base. Ensure you have the branch checked out. Then please run |
This PR adds support for fill on strokes while using the fill tool as requested in #2615.