Skip to content

refactor: [TRTLLM-6150] Refactor moe permute and finalize op by removing duplicated code #5557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jun 30, 2025

Conversation

limin2021
Copy link
Collaborator

@limin2021 limin2021 commented Jun 27, 2025

https://jirasw.nvidia.com/browse/TRTLLM-6150 [infra] : Refactor moe permute and finalize op by removing duplicated code

Description

Refactor moe permute and finalize op by reusing the kernel code in moe_kernels.cu to make it easy to maintain.

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

limin2021 added 12 commits June 23, 2025 19:55
Signed-off-by: Mindy Li <11663212+limin2021@users.noreply.github.com>
Signed-off-by: Mindy Li <11663212+limin2021@users.noreply.github.com>
Signed-off-by: Mindy Li <11663212+limin2021@users.noreply.github.com>
Signed-off-by: Mindy Li <11663212+limin2021@users.noreply.github.com>
Signed-off-by: Mindy Li <11663212+limin2021@users.noreply.github.com>
Signed-off-by: Mindy Li <11663212+limin2021@users.noreply.github.com>
…-final-op

Signed-off-by: Mindy Li <11663212+limin2021@users.noreply.github.com>
Signed-off-by: Mindy Li <11663212+limin2021@users.noreply.github.com>
…-final-op

Signed-off-by: Mindy Li <11663212+limin2021@users.noreply.github.com>
Signed-off-by: Mindy Li <11663212+limin2021@users.noreply.github.com>
Signed-off-by: Mindy Li <11663212+limin2021@users.noreply.github.com>
Signed-off-by: Mindy Li <11663212+limin2021@users.noreply.github.com>
@limin2021 limin2021 requested a review from a team as a code owner June 27, 2025 23:00
@limin2021 limin2021 requested review from litaotju and lucaslie June 27, 2025 23:00
Signed-off-by: Mindy Li <11663212+limin2021@users.noreply.github.com>
Signed-off-by: Mindy Li <11663212+limin2021@users.noreply.github.com>
@limin2021 limin2021 requested a review from djns99 June 27, 2025 23:16
@limin2021 limin2021 changed the title Refactor moe kernel Refactor moe permute and finalize op by removing duplicated code Jun 27, 2025
@limin2021
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10182 [ run ] triggered by Bot

Signed-off-by: Mindy Li <11663212+limin2021@users.noreply.github.com>
@limin2021 limin2021 force-pushed the refactor-moe-kernel branch from b0a7e61 to 1a37e98 Compare June 27, 2025 23:34
@limin2021
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10183 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10182 [ run ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10183 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #7517 completed with status: 'FAILURE'

Copy link
Collaborator

@djns99 djns99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks! Does this also remove the old duplicated versions?

@limin2021 limin2021 force-pushed the refactor-moe-kernel branch from 9d21f42 to 799f23c Compare June 30, 2025 01:14
Signed-off-by: Mindy Li <11663212+limin2021@users.noreply.github.com>
@limin2021 limin2021 force-pushed the refactor-moe-kernel branch from 799f23c to 3cab1dc Compare June 30, 2025 01:16
Signed-off-by: Mindy Li <11663212+limin2021@users.noreply.github.com>
Signed-off-by: Mindy Li <11663212+limin2021@users.noreply.github.com>
@yuxianq yuxianq changed the title Refactor moe permute and finalize op by removing duplicated code refactor: [TRTLLM-6150] Refactor moe permute and finalize op by removing duplicated code Jun 30, 2025
Signed-off-by: Mindy Li <11663212+limin2021@users.noreply.github.com>
@limin2021
Copy link
Collaborator Author

/bot run

Signed-off-by: Mindy Li <11663212+limin2021@users.noreply.github.com>
Signed-off-by: Mindy Li <11663212+limin2021@users.noreply.github.com>
@tensorrt-cicd
Copy link
Collaborator

PR_Github #10295 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10295 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #7612 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@litaotju litaotju merged commit 16fc993 into NVIDIA:main Jun 30, 2025
3 checks passed
Shunkangz pushed a commit to Shunkangz/TensorRT-LLM that referenced this pull request Jul 2, 2025
…ing duplicated code (NVIDIA#5557)

Signed-off-by: Mindy Li <11663212+limin2021@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants