Refactor MAC address detection #1991
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MAC address detection didn't work on devices where PhotonVision doesn't manage the networking, as the logic pulled the interface name from the config. It also repeatedly spammed the logs with messages, which is super annoying and makes the logs harder to navigate. The system has been modified to use Java's NetworkInterface class to find a network interface on devices where PhotonVision doesn't manage networking, and the extra debug log has been removed since it doesn't tell us any information.
Resolves #1990.
Meta
Merge checklist: