feat: add ThreadAutoArchiveDuration enum #2826

BOXERRMD · 2025-07-08T13:32:57Z

Add an enumeration ThreadAutoArchiveDuration to get time before the thread was archived.

The selected enumeration value is automatically retrieved. You can always set the archiving time as a number without using this enumeration.

Summary

This pull request doesn't make any corrections to the code, but adds an enumeration to help find the available thread archive times.
It's not necessarily necessary, but it makes the code easier to read and understand.

Information

This PR fixes an issue.
This PR adds something new (e.g. new method or parameters).
This PR is a breaking change (e.g. methods or parameters removed/renamed).
This PR is not a code change (e.g. documentation, README, typehinting,
examples, ...).

Checklist

I have searched the open pull requests for duplicates.
If code changes were made then they have been tested.
- I have updated the documentation to reflect the changes.
If type: ignore comments were used, a comment is also left explaining why.
I have updated the changelog to include these changes.

Add an enumeration ThreadAutoArchiveDuration to get time before the thread was archived. The selected enumeration value is automatically retrieved. You can always set the archiving time as a number without using this enumeration.

Paillat-dev

I don't really see the benefit of this.

BOXERRMD · 2025-07-08T13:47:42Z

It just brings more understanding to the code. Yes, the modification isn't necessarily important, but it avoids having numbers that can be boring to read, and gives a better understanding of the time provided. You can even use enumeration to enable interactive modification with a bot without having to put in the four possibilities and just use enumeration.
(I'm trying to defend my idea because I had this problem at one point and I had to ask on the discord support to find out what archiving times were available :') )

Paillat-dev · 2025-07-08T14:00:44Z

discord/enums.py

@@ -1078,6 +1079,15 @@ class SubscriptionStatus(Enum):
    inactive = 2


+class ThreadAutoArchiveDuration(Enum):


If you use IntEnum here you don't have to do all of the shenanigans with .value

oh, interesting
thanks for the tips ^^
I can make change and commit for check ?

I have make changes

Paillat-dev · 2025-07-08T15:28:20Z

discord/channel.py

+        if "default_auto_archive_duration" in options:
+            default_auto_archive_duration = options["default_auto_archive_duration"]
+            options["default_auto_archive_duration"] = (
+                default_auto_archive_duration
+                if isinstance(default_auto_archive_duration, (int, float))
+                else default_auto_archive_duration.value
+            )
+


Suggested change

if "default_auto_archive_duration" in options:

default_auto_archive_duration = options["default_auto_archive_duration"]

options["default_auto_archive_duration"] = (

default_auto_archive_duration

if isinstance(default_auto_archive_duration, (int, float))

else default_auto_archive_duration.value

)

Paillat-dev · 2025-07-08T15:34:06Z

discord/threads.py

@@ -632,6 +634,7 @@ async def edit(
        auto_archive_duration: :class:`int`
            The new duration in minutes before a thread is automatically archived for inactivity.
            Must be one of ``60``, ``1440``, ``4320``, or ``10080``.
+            **ThreadAutoArchiveDuration** enum can be used for better understanding.


Suggested change

**ThreadAutoArchiveDuration** enum can be used for better understanding.

:class:`ThreadAutoArchiveDuration` can be used alternatively.

Paillat-dev · 2025-07-08T15:37:13Z

discord/enums.py

@@ -1078,6 +1080,15 @@ class SubscriptionStatus(Enum):
    inactive = 2


+class ThreadAutoArchiveDuration(enum.IntEnum):


Suggested change

class ThreadAutoArchiveDuration(enum.IntEnum):

class ThreadArchiveDuration(enum.IntEnum):

Rename it here and then use from ... import ThreadArchiveDuration as ThreadArchiveDurationEnum

Paillat-dev · 2025-07-08T15:38:02Z

discord/channel.py

@@ -1130,6 +1133,7 @@ async def edit(self, *, reason=None, **options):
        default_auto_archive_duration: :class:`int`
            The new default auto archive duration in minutes for threads created in this channel.
            Must be one of ``60``, ``1440``, ``4320``, or ``10080``.
+            **ThreadAutoArchiveDuration** enum can be used for better understanding.


Suggested change

**ThreadAutoArchiveDuration** enum can be used for better understanding.

:class:`ThreadAutoArchiveDuration` can be used alternatively.

BOXERRMD · 2025-07-08T15:47:10Z

I have apply changes ! :D

Paillat-dev

Also, please add the enum to the docs in https://github.com/Pycord-Development/pycord/blob/master/docs/api/enums.rst
Look at the other enums in the file and reproduce how they are declared.

Paillat-dev · 2025-07-08T15:56:07Z

discord/channel.py

@@ -39,6 +39,9 @@
    InviteTarget,
    SortOrder,
    StagePrivacyLevel,
+)
+from .enums import ThreadArchiveDuration as ThreadAutoArchiveDuration


Suggested change

from .enums import ThreadArchiveDuration as ThreadAutoArchiveDuration

from .enums import ThreadArchiveDuration as ThreadArchiveDurationEnum

I think it's better if you import it as ThreadArchiveDurationEnum

Paillat-dev · 2025-07-08T16:02:13Z

discord/enums.py

@@ -25,6 +25,7 @@

 from __future__ import annotations

+import enum


Suggested change

import enum

from enum import IntEnum

Paillat-dev · 2025-07-08T16:02:23Z

discord/enums.py

@@ -1078,6 +1080,15 @@ class SubscriptionStatus(Enum):
    inactive = 2


+class ThreadArchiveDuration(enum.IntEnum):


Suggested change

class ThreadArchiveDuration(enum.IntEnum):

class ThreadArchiveDuration(IntEnum):

Dorukyum · 2025-07-08T16:04:32Z

I find this not very necessary. See the documentation and the type ThreadArchiveDuration.

pycord/discord/types/threads.py

Line 36 in 1c65fc8

ThreadArchiveDuration = Literal[60, 1440, 4320, 10080]

BOXERRMD · 2025-07-08T16:07:21Z

I find that just the figures as shown remain rather unclear about the actual time given. The addition I'm proposing doesn't add anything vital, but I think it makes the code easier to understand, without being compulsory.

Paillat-dev · 2025-07-08T16:08:23Z

I find this not very necessary.

Same to be fair, but as long as it's just an Enum class I feel like the changes are acceptable, unlike the original proposition which added too much verbosity. Although this is not strictly necessary.

CHANGELOG.md

Co-authored-by: Paillat <jeremiecotti@ik.me> Signed-off-by: BOXER <130167557+BOXERRMD@users.noreply.github.com>

docs/api/enums.rst

Co-authored-by: Paillat <jeremiecotti@ik.me> Signed-off-by: BOXER <130167557+BOXERRMD@users.noreply.github.com>

BOXERRMD · 2025-07-08T16:14:57Z

👍 I have make changes !

Paillat-dev

As fare as code quality goes, lgtm.

From a usefulness perspective, I don't think this is strictly necessary but I feel like it's a plus to have.

feat: add ThreadAutoArchiveDuration enum

3679443

Add an enumeration ThreadAutoArchiveDuration to get time before the thread was archived. The selected enumeration value is automatically retrieved. You can always set the archiving time as a number without using this enumeration.

BOXERRMD requested a review from a team as a code owner July 8, 2025 13:32

pullapprove4 bot requested a review from BobDotCom July 8, 2025 13:33

pullapprove4 bot added PA: All Contributors pending PA: Maintainers pending labels Jul 8, 2025

style(pre-commit): auto fixes from pre-commit.com hooks

1424acf