Bump typing gems and implement required changes #3610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
- Since Sorbet now supports type aliases in RBS, we can remove the shims
- Abstract methods now are required to raise a NotImplementedError
- However, because the RuboCop addon does NOT implement the `version`
method yet, we need to rescue NotImplementedError in the server or
it never starts.
st0012
changed the title
st0012
added
chore
vinistock
reviewed
Jun 17, 2025
| version = begin | ||
| addon.version | ||
| rescue NotImplementedError | ||
| "[unknown version]" |
There was a problem hiding this comment.
Suggested change
| "[unknown version]" | |
| nil |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Bump Sorbet to get the latest RBS support
Implementation
versionmethod yet, we need to rescueNotImplementedErrorin the server or it never starts.I think raising runtime error for abstract methods imposes a great risk for Ruby LSP since we don't have control on how addons are implemented. Granted that we were lucky that
addon.versioncould previously benilwithout any trouble, but now that we're even more vulnerable to addon implementation breaking Ruby LSP.(I know it'd have been the case if we still use RBI for abstract methods)
Automated Tests
Manual Tests