Skip to content

refactor: resource_manager.py #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

VasigaranAndAngel
Copy link
Collaborator

@VasigaranAndAngel VasigaranAndAngel commented Jun 12, 2025

Summary

  • Type annotation fixes
  • Made ResourceManager singleton
  • Simplified how the data is loaded and cached

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable

@CyanVoxel CyanVoxel added Type: Refactor Code that needs to be restructured or cleaned up Status: Review Needed A review of this is needed labels Jun 12, 2025
@CyanVoxel CyanVoxel moved this to 🏓 Ready for Review in TagStudio Development Jun 12, 2025
@Computerdores Computerdores moved this from 🏓 Ready for Review to 👀 In review in TagStudio Development Jun 13, 2025
@Computerdores Computerdores moved this from 👀 In review to 🍃 Pending Merge in TagStudio Development Jun 17, 2025
@Computerdores Computerdores added Status: Mergeable The code is ready to be merged and removed Status: Review Needed A review of this is needed labels Jun 17, 2025
@CyanVoxel
Copy link
Member

Thank you for the changes!

@CyanVoxel CyanVoxel merged commit 4e72227 into TagStudioDev:main Jun 27, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from 🍃 Pending Merge to ✅ Done in TagStudio Development Jun 27, 2025
@CyanVoxel CyanVoxel removed the Status: Mergeable The code is ready to be merged label Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Refactor Code that needs to be restructured or cleaned up
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants