Enhancement: Add new acf/fields/icon_picker/{tab_name}/icons filter
#177
+227
−176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
commented
Jun 17, 2025
| $custom_icons = apply_filters( 'acf/fields/icon_picker/' . $name . '/icons', array(), $field ); | ||
|
|
||
| if ( is_array( $custom_icons ) && ! empty( $custom_icons ) ) { | ||
| $this->render_icon_list_tab( $name, $custom_icons ); |
There was a problem hiding this comment.
PHPStan is right about this: The function only supports one argument.
Since I carried the code over from upstream, it looks like it's a bug there.
This means that the newly introduced acf/fields/icon_picker/{tab_name}/icons filter won't actually work there. This leaves us with two options:
- We punt this PR for now (until it's fixed upstream), or
- we fix it here.
cbravobernal
added
Backport from upstream
[Type] Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress. Testing instructions to follow.
Corresponds to this changeset: https://plugins.trac.wordpress.org/changeset/3289772/advanced-custom-fields/tags/6.4.1/includes/fields/class-acf-field-icon_picker.php