Fix: Term counts should not be recalculated when a post transitions between statuses that are not counted

[hbhalodia]

Trac ticket: https://core.trac.wordpress.org/ticket/63562

• Updated the function _update_term_count_on_transition_post_status which is hooked to transition_post_status action, and added condition to only recalculate when the new status or old status is publish.
• Add condition to not recalculate on same status.

---

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props hbhalodia, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[hbhalodia]

Added this to not recalculate when both status are same, Based on

wordpress-develop/src/wp-includes/ms-blogs.php

Lines 911 to 924 in 6ac0efd

	function _update_posts_count_on_transition_post_status( $new_status, $old_status, $post = null ) {
	if ( $new_status === $old_status ) {
	return;
	}
	if ( 'post' !== get_post_type( $post ) ) {
	return;
	}
	if ( 'publish' !== $new_status && 'publish' !== $old_status ) {
	return;
	}
	update_posts_count();

[github-actions]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• The Plugin and Theme Directories cannot be accessed within Playground.
• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
  it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

[mukeshpanchal27]

It just needs to respect other statuses added via the update_post_term_count_statuses filter too.

The implementation for filter is missing.

[hbhalodia]

The implementation for filter is missing.

Yes, Thanks for the note, I am adding the implementation for the same.

[hbhalodia]

Hi @mukeshpanchal27, I have implemented the fix to respect the filter, Let me know if that is correct approach or need to update with some other logic.

Thank You,

[mukeshpanchal27]

Let's add unit tests that validate the updated functionality.

[hbhalodia]

Hi @mukeshpanchal27,

I reviewed this and looked into how we can accommodate the suggested test. However, it seems that the existing tests already cover the intended functionality:

The tests in this file already handle the scenario: https://github.com/WordPress/wordpress-develop/blob/trunk/tests/phpunit/tests/term/termCounts.php

For example, we've added a check to ensure that if both the old and new statuses are the same, the term count remains unchanged. This specific case is already covered here:

wordpress-develop/tests/phpunit/tests/term/termCounts.php

Line 172 in ebace79

public function test_term_count_transitions_update_term_counts( $original_post_status, $new_post_status, $change ) {

The data provider for that test includes conditions where both statuses are the same, which ensures no change in the term count unless one of the statuses is publish.

Additionally, we already have a test for the update_post_term_count_statuses filter, which covers scenarios where a custom status is added:

wordpress-develop/tests/phpunit/tests/term/termCounts.php

Line 242 in ebace79

public function test_term_count_changes_for_update_post_term_count_statuses_filter( $post_status, $change ) {

So I am not sure if we should proceed to add the test, because I do not see any test specific to this function _update_term_count_on_transition_post_status added earlier as it seems test functionality covered by the mentioned file.

Let me know if we need to add a specific test for this?

Thank You,