Add unit test for get_post_galleries() when parsing malformed [gallery] shortcodes. #9005
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a PHPUnit test that reproduces the issue reported in Trac #63577, where a warning is triggered when
get_post_galleries()
encounters malformed[gallery]
shortcodes.Specifically, the issue occurs when the gallery array lacks the expected
'id'
key, and functions likewp_list_pluck()
assume it exists. This test demonstrates how[gallery]
,[gallery ids]
, or[gallery ids=""]
can result in a malformed output that reproduces the warning.Testing Instructions
Run the test class:
Trac ticket: https://core.trac.wordpress.org/ticket/63577
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.