Skip to content

Use API for MariaDB version test #9009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

todeveni
Copy link

Use data from MariaDB API and re-enable test.
This patch assumes that when a release is missing from said API, it'll be EOL.

Trac ticket: https://core.trac.wordpress.org/ticket/63586

Copy link

github-actions bot commented Jun 18, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props skithund, peterwilsoncc.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the version is unlisted we can fail the test immediately and avoid the need to fake the date when it's unknown.

Comment on lines 83 to 86
// If the release ID is not found, expect it to be an EOL release and return one day before the current date.
if ( ! isset( $mariadb_eol ) ) {
$mariadb_eol = gmdate( 'Y-m-d', strtotime( '-1 day' ) );
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// If the release ID is not found, expect it to be an EOL release and return one day before the current date.
if ( ! isset( $mariadb_eol ) ) {
$mariadb_eol = gmdate( 'Y-m-d', strtotime( '-1 day' ) );
}
// If the release ID is not found the version is unsupported.
if ( ! isset( $mariadb_eol ) ) {
$this->fail( "{$matches[1]} is not included in MariaDB's list of supported versions. Remember to update the WordPress.org Requirements page, too." );
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants