Skip to content

fix: FLIP animation for tabs #8407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 20, 2025
Merged

fix: FLIP animation for tabs #8407

merged 4 commits into from
Jun 20, 2025

Conversation

snowystinger
Copy link
Member

@snowystinger snowystinger commented Jun 18, 2025

Closes

Followed https://css-tricks.com/animating-layouts-with-the-flip-technique/

To test, use different orientations, density, locale direction, resizing containers, etc and make sure the tabline doesn't end up in any bad places

Note, focus ring should not be included in the animation for now. We'd have to figure out how to handle manual activation.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Jun 18, 2025

Build successful! 🎉

@rspbot
Copy link

rspbot commented Jun 18, 2025

Build successful! 🎉

@rspbot
Copy link

rspbot commented Jun 19, 2025

Build successful! 🎉

Copy link
Member

@devongovett devongovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niiiice!

Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snowystinger snowystinger added this pull request to the merge queue Jun 20, 2025
Merged via the queue into main with commit 8884fc7 Jun 20, 2025
31 checks passed
@snowystinger snowystinger deleted the fix-flip-animation-for-tabs branch June 20, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants