Skip to content

fix: <Tab> and <TabPanel> id type mismatch #8423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 26, 2025
Merged

fix: <Tab> and <TabPanel> id type mismatch #8423

merged 4 commits into from
Jun 26, 2025

Conversation

kidonng
Copy link
Contributor

@kidonng kidonng commented Jun 19, 2025

Closes #8422

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

N/A

🧢 Your Project:

N/A

snowystinger
snowystinger previously approved these changes Jun 19, 2025
View reviewed changes
reidbarber
reidbarber previously approved these changes Jun 19, 2025
View reviewed changes
Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@reidbarber reidbarber dismissed their stale review June 19, 2025 15:08

lint failing

snowystinger
snowystinger previously approved these changes Jun 25, 2025
View reviewed changes
@snowystinger
Copy link
Member

Thanks again, can you follow the instructions here? https://react-spectrum.adobe.com/contribute.html#contributor-license-agreement or let us know if you cannot sign it

@kidonng
Copy link
Contributor Author

kidonng commented Jun 26, 2025

Thanks, I have just signed it.

@yihuiliao yihuiliao added this pull request to the merge queue Jun 26, 2025
Merged via the queue into adobe:main with commit 7b35299 Jun 26, 2025
31 checks passed
littlebtc added a commit to otohime-site/web that referenced this pull request Jul 23, 2025
@littlebtc
fix: remove tab workaround after adobe/react-spectrum#8423
a24a9a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snowystinger snowystinger

@yihuiliao yihuiliao

@reidbarber reidbarber

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<Tab> and <TabPanel> id type mismatch
4 participants
@kidonng @snowystinger @reidbarber @yihuiliao