feat(textfield): Add proper ARIA labeling to validation icon #8429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razvanborsan
force-pushed
the
textfield-accessible-validation-icons
branch
from
0838e10 to
517ac65
Compare
razvanborsan
force-pushed
the
textfield-accessible-validation-icons
branch
from
517ac65 to
d814c97
Compare
snowystinger
approved these changes
Jun 22, 2025
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "valid": "Valid" | |||
There was a problem hiding this comment.
Will need to consult accessibility on the best string here. The invalid announced "invalid text" on MacOS VO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Pull Request Checklist:
📝 Test Instructions:
yarn startand view TextField "with valid state" storiesaria-label="Valid"aria-describedbypointing to validation iconyarn test- all tests pass🧢 Your Project:
Personal contribution to improve React Spectrum accessibility
Description: Adds ARIA labeling to TextField validation icons for improved screen reader accessibility.
Changes:
aria-label="Valid"to checkmark iconaria-describedbyreference when in valid state