-
Notifications
You must be signed in to change notification settings - Fork 3.7k
GH-46748: [C++] Initial port on AIX #46749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format?
or
See also: |
|
Could you fix lint errors? How to maintain AIX support? See also: #46002 |
Hi @kou
|
https://github.com/apache/arrow/actions/runs/15561745991/job/43843132193?pr=46749#step:7:148
|
I missed to see this in lint report. Thanks for pointing out. |
@kou |
Do you have any idea how to maintain AIX support? |
I will setup Jenkins CI job for AIX locally for this package and will build main branch on daily basis. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
OK. Let's start with the approach.
If self-hosted GitHub Runner on AIX is provided, we can add it to our CI.
Thanks @kou for reviewing/merging this. |
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit bd31f83. There were 119 benchmark results with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Rationale for this change
Fix build errors on AIX.
What changes are included in this PR?
Compilation issue fixed as mentioned in the above issue.
Are these changes tested?
Yes.
Compiled with below settings for initial port.
cmake . -B build --preset ninja-debug-minimal -DCMAKE_INSTALL_PREFIX=/usr/local -DCMAKE_AIX_SHARED_LIBRARY_ARCHIVE=ON -DARROW_CSV=ON -DARROW_JSON=ON -DARROW_FILESYSTEM=ON -DARROW_COMPUTE=ON -DARROW_DATASET=ON
Are there any user-facing changes?
NA