Skip to content

GH-46820: [CI][Integration] Use Node.js 20 by default #46821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025

Conversation

kou
Copy link
Member

@kou kou commented Jun 16, 2025

Rationale for this change

We're using NODE=XX in .env as the default Node.js version.

What changes are included in this PR?

Use NODE=20 in .env.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

Copy link

⚠️ GitHub issue #46820 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Jun 16, 2025
@kou kou force-pushed the ci-node-js-20 branch from 5e8e6ad to 8ac2eb8 Compare June 16, 2025 02:19
@kou
Copy link
Member Author

kou commented Jun 16, 2025

https://github.com/apache/arrow/actions/runs/15670314882/job/44141128787?pr=46821#step:12:305

  #8 22.41   nodejs-20.18.1-hc55a1b2_0.conda                       17MB

Node.js 20 was used.

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration job is flaky but does not seem related to the PR. It has been flaky for a while, we should probably open an issue and investigate where the flakyness is coming from.

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jun 16, 2025
@kou kou merged commit a974df4 into apache:main Jun 16, 2025
35 of 36 checks passed
@kou kou deleted the ci-node-js-20 branch June 16, 2025 08:53
@kou kou removed the awaiting merge Awaiting merge label Jun 16, 2025
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit a974df4.

There were 122 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

alinaliBQ pushed a commit to Bit-Quill/arrow that referenced this pull request Jun 17, 2025
…6821)

### Rationale for this change

We're using `NODE=XX` in `.env` as the default Node.js version.

### What changes are included in this PR?

Use `NODE=20` in `.env`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#46820

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants