Skip to content

MINOR: [Ruby] Simplify dense union array RecordBatch creation in tests #46850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2025

Conversation

otegami
Copy link
Contributor

@otegami otegami commented Jun 18, 2025

Rationale for this change

Addressing TODO comment in test, replace manual construction of DenseUnionArray with direct RecordBatch.new call.

What changes are included in this PR?

This change simplifies the build_record_batch in test/raw-records/test-dense-union-array.rb

Are these changes tested?

Yes

Are there any user-facing changes?

No, this is a test-only change.

Replace manual construction of DenseUnionArray with
direct RecordBatch.new call, addressing TODO comment.
@otegami otegami requested a review from kou as a code owner June 18, 2025 10:39
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@otegami otegami changed the title [Ruby] Simplify dense union array RecordBatch creation in tests MINOR: [Ruby] Simplify dense union array RecordBatch creation in tests Jun 18, 2025
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions github-actions bot added awaiting merge Awaiting merge awaiting changes Awaiting changes and removed awaiting review Awaiting review awaiting merge Awaiting merge labels Jun 18, 2025
@kou kou merged commit 01e8a60 into apache:main Jun 19, 2025
9 checks passed
@kou kou removed the awaiting changes Awaiting changes label Jun 19, 2025
@otegami otegami deleted the simplify-dense-union-record-batch-creation branch June 19, 2025 02:17
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 01e8a60.

There were 119 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants