KAFKA-18486: Remove ReplicaManager#becomeLeaderOrFollower #20037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandboat
reviewed
Jun 25, 2025
chia7712
reviewed
Jun 26, 2025
| byte leaderRecoveryState; | ||
|
|
||
| public PartitionState() { | ||
| this.topicName = ""; |
There was a problem hiding this comment.
Could you please remove the default constructor by initializing these variables directly?
public class PartitionState {
String topicName = "";
int partitionIndex = 0;
int leader = 0;| completeDelayedOperationsWhenNotPartitionLeader(partition.topicPartition, partition.topicId) | ||
| } | ||
|
|
||
| if (isShuttingDown.get()) { |
There was a problem hiding this comment.
isShuttingDown is useless now, so could you please remove it
Thanks for review, we can't remove |
chia7712
reviewed
Jun 27, 2025
| @@ -354,7 +354,6 @@ class BrokerServer( | |||
| logDirFailureChannel = logDirFailureChannel, | |||
| alterPartitionManager = alterPartitionManager, | |||
| brokerTopicStats = brokerTopicStats, | |||
| isShuttingDown = isShuttingDown, | |||
There was a problem hiding this comment.
we could remove isShuttingDown from BrokerServer, right?
chia7712
approved these changes
Jun 29, 2025
|
The follow-ups are listed below.
|
chia7712
pushed a commit
that referenced
this pull request
Jun 30, 2025
Remove FlattenedIterator. It’s no longer used anywhere after #20037. Reviewers: TengYao Chi <kitingiao@gmail.com>, Lan Ding <isDing_L@163.com>, Chia-Ping Tsai <chia7712@gmail.com>
jiafu1115
pushed a commit
to jiafu1115/kafka
that referenced
this pull request
Jul 2, 2025
The PR do following: 1. Remove ReplicaManager#becomeLeaderOrFollower. 2. Remove `LeaderAndIsrRequest` and `LeaderAndIsrResponse` 3. Migrate `LeaderAndIsrRequest.PartitionState` to server-common module and change to `PartitionState` 4. Remove `ControllerEpoch` from PartitionState 5. Remove `isShuttingDown` from BrokerServer and ReplicaManager Reviewers: Kuan-Po Tseng <brandboat@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
jiafu1115
pushed a commit
to jiafu1115/kafka
that referenced
this pull request
Jul 2, 2025
Remove FlattenedIterator. It’s no longer used anywhere after apache#20037. Reviewers: TengYao Chi <kitingiao@gmail.com>, Lan Ding <isDing_L@163.com>, Chia-Ping Tsai <chia7712@gmail.com>
jiafu1115
pushed a commit
to jiafu1115/kafka
that referenced
this pull request
Jul 3, 2025
The PR do following: 1. Remove ReplicaManager#becomeLeaderOrFollower. 2. Remove `LeaderAndIsrRequest` and `LeaderAndIsrResponse` 3. Migrate `LeaderAndIsrRequest.PartitionState` to server-common module and change to `PartitionState` 4. Remove `ControllerEpoch` from PartitionState 5. Remove `isShuttingDown` from BrokerServer and ReplicaManager Reviewers: Kuan-Po Tseng <brandboat@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
jiafu1115
pushed a commit
to jiafu1115/kafka
that referenced
this pull request
Jul 3, 2025
Remove FlattenedIterator. It’s no longer used anywhere after apache#20037. Reviewers: TengYao Chi <kitingiao@gmail.com>, Lan Ding <isDing_L@163.com>, Chia-Ping Tsai <chia7712@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR do following:
LeaderAndIsrRequestandLeaderAndIsrResponseLeaderAndIsrRequest.PartitionStateto server-common moduleand change to
PartitionStateControllerEpochfrom PartitionStateisShuttingDownfrom BrokerServer and ReplicaManagerReviewers: Kuan-Po Tseng brandboat@gmail.com, Chia-Ping Tsai
chia7712@gmail.com